chore(devcontainer): fix dockerfile broken yarn repo in base image

[UnschooledGamer]

No description provided.

[greptile-apps]

Greptile Summary

This PR fixes the broken Yarn APT repository present in the mcr.microsoft.com/devcontainers/java:1-21-bullseye base image by removing /etc/apt/sources.list.d/yarn.list before running apt-get update, and migrates the devcontainer config from a bare image reference to a Dockerfile build. It also bumps the Android platform and build-tools from 35 → 36, removes the redundant Java devcontainer feature, and delegates Node.js installation to the ghcr.io/devcontainers/features/node:1 feature (commenting out the previous fnm-based install). All remaining findings are P2.

Confidence Score: 5/5

Safe to merge — the core fix is correct and all findings are minor style suggestions (P2).

No P0 or P1 issues found. The broken-yarn-repo fix is straightforward and correct. The remaining comments are about dead ARG/package and a redundant pnpm install, none of which affect runtime correctness.

No files require special attention.

Important Files Changed

Filename	Overview
.devcontainer/Dockerfile	Fixes broken yarn repo by removing /etc/apt/sources.list.d/yarn.list; bumps Android platform/build-tools to 36; comments out fnm/Node.js install (delegated to devcontainer node feature); adds unused curl and leaves dead NODE_VERSION ARG
.devcontainer/devcontainer.json	Switches from a plain image to a Dockerfile build; removes java feature (handled by base image); aligns android-sdk feature to platform/build-tools 36; adds node feature; sets remoteUser=root and overrideCommand=true; postCreateCommand redundantly installs pnpm when the node feature already does

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[VS Code opens devcontainer] --> B[Build Dockerfile\nfrom base java:1-21-bullseye]
    B --> B1[rm broken yarn.list]
    B1 --> B2[apt-get: wget, unzip, curl]
    B2 --> B3[Install Gradle 8.11]
    B3 --> B4[Install Android SDK\nplatform-36 / build-tools-36.0.0]
    B4 --> C[Apply devcontainer features]
    C --> C1[android-sdk feature\nplatform=36, build_tools=36.0.0]
    C --> C2[node feature\nLTS + pnpm latest]
    C1 --> D[postCreateCommand]
    C2 --> D
    D --> D1[npm i -g pnpm\n⚠ redundant — already installed by node feature]
    D1 --> D2[pnpm run setup]
    D2 --> E[Container ready]

Loading

_{Reviews (3): Last reviewed commit: "Update devcontainer.json" | Re-trigger Greptile}

[UnschooledGamer]

@greptileai

[UnschooledGamer]

@greptileai