fix: show full error when terminal installation fails

[bajrangCoder]

No description provided.

[greptile-apps]

Greptile Summary

This PR refactors Terminal.js to use async/await throughout, accumulates stderr lines into lastInstallError for richer failure messages, and extracts a shared formatError helper that is also consumed by the new formatInstallLog in terminalManager.js. The two previously-noted issues (stderr accumulation and duplicated formatError logic) are now addressed.

Confidence Score: 4/5

Safe to merge; only a minor unhandled-rejection gap in the non-install startup path.

No P0 or P1 issues found. A single P2 style issue (missing .catch() on the non-install Executor chain) is the only concern. Core installation error-reporting logic is correct and the previously flagged issues have been resolved.

src/plugins/terminal/www/Terminal.js — non-install else branch of startAxs

Important Files Changed

Filename	Overview
src/plugins/terminal/www/Terminal.js	Major refactor: async/await, Promise-wrapped helpers, accumulated stderr in lastInstallError, and exported formatError. Non-install else branch lacks a .catch() on the Executor.start chain.
src/components/terminal/terminalManager.js	Adds formatInstallLog helper and rest-param err_logger; reads Terminal.lastInstallError on non-zero exit. Logic is correct given new Terminal.js contract.

Sequence Diagram

sequenceDiagram
    participant TM as terminalManager.js
    participant T as Terminal.js
    participant E as Executor

    TM->>T: install(logger, err_logger)
    Note over T: lastInstallError = ""
    T->>T: uninstall, download, extract
    T->>T: startAxs(installing=true)
    T->>E: Executor.start("sh", callback)
    E-->>T: uuid
    T->>E: Executor.write(uuid, init-sandbox.sh)
    loop stderr events
        E-->>T: type=stderr, data
        Note over T: lastError accumulates lines
    end
    E-->>T: type=exit, data
    alt exit code 0
        T-->>TM: true
        TM-->>TM: return success
    else non-zero exit
        Note over T: lastInstallError = exit code + lastError
        T-->>TM: false
        TM-->>TM: return error from lastInstallError
    end

Loading

_{Reviews (2): Last reviewed commit: "fix" | Re-trigger Greptile}