[CHORE] Acon 2.0 1차 QA 대응 (#202) #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurim830
approved these changes
Jun 17, 2025
Comment on lines
26
to
29
| func removeToken() { | ||
| UserDefaults.standard.removeObject(forKey: StringLiterals.UserDefaults.accessToken) | ||
| UserDefaults.standard.removeObject(forKey: StringLiterals.UserDefaults.refreshToken) | ||
| } |
Collaborator
There was a problem hiding this comment.
🐿️ 이렇게 해도 좋을 것 같기도 하고 굳이 싶기도 하고.... 어떤 게 나을까요?
[StringLiterals.UserDefaults.accessToken,
StringLiterals.UserDefaults.refreshToken].foreach { UserDefaults.standard.removeObject(forKey: $0) }
Comment on lines
26
to
29
| toastView.snp.makeConstraints { | ||
| $0.bottom.equalToSuperview().inset(Int(ScreenUtils.height)*bottomInset/780) | ||
| $0.bottom.equalToSuperview().inset(ScreenUtils.heightRatio*Double(bottomInset)) | ||
| $0.centerX.equalToSuperview() | ||
| } |
Collaborator
There was a problem hiding this comment.
🐿️🐿️ label, button, toast와 같은 컴포넌트는 주로 텍스트와 함께 사용되는데요,
텍스트 폰트 크기는 디바이스에 관계 없이 동일하기 때문에 height에는 ratio를 곱하지 않는 편이 자연스러울 것 같아요.
또한, cornerRadius가 고정값으로 적용되었을 경우, Height이 변하게 되면 UI가 어그러질 수도 있기 때문에 안전하게 고정값으로 넣으면 좋을 것 같습니다! 어떻게 생각하시나요?
Contributor
Author
There was a problem hiding this comment.
앗 토스트 자체의 height이 아닌 bottom inset이라 상관없을 것 같습니다! 또 안 곱하면 피그마와 UI 위치가 많이 달라져요 ㅠㅠ
Comment on lines
+140
to
+141
| if flowType == .login { | ||
| NavigationUtils.navigateToTabBar() |
Collaborator
There was a problem hiding this comment.
🐿️ flow가 회원가입일 경우 이렇게 되는 거 맞을까요?
단순 로그인에서는 온보딩 VC가 열리지 않으니, flowType을 로그인 대신 회원가입이라고 하면 어떨까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐿️ Pull Requests
🪵 작업 브랜치
🥔 작업 내용
다음과 같은 QA 사항들을 대응했습니다.
Feature
Fix
Chore
🚨 참고 사항
아직 대응 안 한 1차 QA ( [기본이미지로 변경 노출] 제외 ) 부탁드립니당~~
디자인 QA
기능 QA
💥 To be sure
🌰 Resolve issue