refactor: flagbind batch helpers and convention sweep#64
Merged
josealekhine merged 4 commits intomainfrom Apr 12, 2026
Merged
Conversation
Signed-off-by: Jose Alekhinne <jose@ctx.ist>
Signed-off-by: Jose Alekhinne <jose@ctx.ist>
Add parallel-slice batch functions to flagbind (BindStringFlagsP, BindStringFlags, BindBoolFlags, BindBoolFlagsP, BindStringFlagShorts, BindStringFlagsPDefault) replacing repetitive one-at-a-time flag registrations across 8 CLI command files. Convention sweep: - hub: rename files (entry_validate→validate_entry, errcheck→err_check), remove const aliases, move magic numbers to config/hub and config/entry, fix predicate naming (isEOF→eof, isAuthErr→authErr) - initialize: rename claudecheck→claude_check, details→detail - steering/types: align docstrings with conventions - compliance: fix TestNoSecretsInTemplates false positive on YAML keys - golangci: extend G101 exclusion to all embed/text/ DescKey files - sysinfo: add missing nolint:gosec for G204 on vm_stat Spec: specs/flagbind-batch-and-convention-sweep.md Signed-off-by: Jose Alekhinne <jose@ctx.ist>
…arser rescue The dead exports test maintained a manual list of platform-specific symbols (linux-only, darwin-only) that appeared dead on the other OS. This list grew with every new platform constant and taught bad habits. Replace with a go/parser sweep that parses ALL .go files regardless of build tags, extracts selector names, and automatically rescues any export referenced from any platform file. No manual maintenance. Spec: specs/flagbind-batch-and-convention-sweep.md Signed-off-by: Jose Alekhinne <jose@ctx.ist>
Deploying ctx with
|
| Latest commit: |
970cdd0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://08e54d74.ctx-bhl.pages.dev |
| Branch Preview URL: | https://feature-ctx-hub-next.ctx-bhl.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor: flagbind batch helpers and convention sweep
Add parallel-slice batch functions to flagbind (BindStringFlagsP,
BindStringFlags, BindBoolFlags, BindBoolFlagsP, BindStringFlagShorts,
BindStringFlagsPDefault) replacing repetitive one-at-a-time flag
registrations across 8 CLI command files.
Convention sweep:
remove const aliases, move magic numbers to config/hub and config/entry,
fix predicate naming (isEOF→eof, isAuthErr→authErr)
Spec: specs/flagbind-batch-and-convention-sweep.md
Signed-off-by: Jose Alekhinne jose@ctx.ist