Skip to content

Conversation

@daved
Copy link
Contributor

@daved daved commented Jan 30, 2023

BugDX-1531 Panic during runtime progress on Windows

@daved daved requested a review from Naatan January 30, 2023 21:15
Naatan
Naatan previously approved these changes Jan 30, 2023
@daved daved changed the base branch from master to version/0-36-0-RC1 January 30, 2023 21:22
@daved daved dismissed Naatan’s stale review January 30, 2023 21:22

The base branch was changed.

@daved
Copy link
Contributor Author

daved commented Jan 30, 2023

@Naatan
Returning the error using errs.Wrap results in the user-facing output of
x Could not install dependencies
The causes for this flow are:

  1. Cannot connect to the build streamer
  2. Could not handle buildstarted event
  3. Could not write to websocket

I think a clearer message is worthwhile.

@Naatan
Copy link
Contributor

Naatan commented Jan 30, 2023

@daved I think the current message is appropriate. The underlying issue is entirely too technical to communicate to the user in a way that is useful.

API's being unreachable is going to bubble up in awkward ways in the state tool, we definitely haven't optimized for that. That can be something we look into in the future, but it's separate from the issue at hand.

@Naatan Naatan merged commit e3972de into version/0-36-0-RC1 Jan 30, 2023
@Naatan Naatan deleted the green/fix_rt_prog_panic.DX-1531 branch January 30, 2023 22:35
@Naatan
Copy link
Contributor

Naatan commented Jan 30, 2023

@daved went ahead and merged it as I'm blocked by this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants