Uninstall on Windows should remove the same files as on macOS/Linux#2401
Merged
mitchell-as merged 2 commits intoversion/0-37-0-RC1from Mar 1, 2023
Merged
Uninstall on Windows should remove the same files as on macOS/Linux#2401mitchell-as merged 2 commits intoversion/0-37-0-RC1from
mitchell-as merged 2 commits intoversion/0-37-0-RC1from
Conversation
mitchell-as
force-pushed
the
mitchell/dx-1614
branch
from
a388064 to
2ef2116
Compare
mitchell-as
changed the title
mitchell-as
force-pushed
the
mitchell/dx-1614
branch
2 times, most recently
from
f98cbbb to
31f5248
Compare
It does not contain cache and config directories. Only for integration tests are the cache and config directories subdirectories.
mitchell-as
force-pushed
the
mitchell/dx-1614
branch
from
31f5248 to
3c85347
Compare
MDrakos
requested changes
Mar 1, 2023
Member
MDrakos
left a comment
MDrakos
left a comment
There was a problem hiding this comment.
This fixes our integration tests CI issues but could legitimately mess with users attempting to uninstall the state tool as part of their CI steps... can we use condition.InTest instead?
MDrakos
approved these changes
Mar 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous fix was erroneously tailored towards the integration tests. It was not deleting the installer exe and install root stub.