Skip to content

Add a bit of lag to the JWT renewal time. #3592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchell-as merged 2 commits into from
Nov 14, 2024
Merged

Add a bit of lag to the JWT renewal time. #3592

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a243fa
Add a bit of lag to the JWT renewal time.
mitchell-as Nov 13, 2024
e862c58
Reduce JWT lifetime instead.
mitchell-as Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/platform/authentication/auth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ type ErrTokenRequired struct{ *locale.LocalizedError }
var errNotYetGranted = locale.NewInputError("err_auth_device_noauth")

// jwtLifetime is the lifetime of the JWT. This is defined by the API, but the API doesn't communicate this.
// We drop a minute from this to avoid race conditions with the API.
const jwtLifetime = (1 * time.Hour) - (1 * time.Minute)
// We drop 10 minutes from this to be on the safe side and avoid race conditions with the API.
const jwtLifetime = (1 * time.Hour) - (10 * time.Minute)

// Auth is the base structure used to record the authenticated state
type Auth struct {
Expand Down