Attach builders to artifacts. #3753
Conversation
Ecosystem namespaces will contain a mix of dynamically-imported artifacts and built artifacts. DI artifacts produced by the star-builder should invoke an ecosystem-specific installation procedure. Artifacts produced by other builders should be installed as normal. Note: uninstallation will not work because depot artifacts are not tied to builders. This will need to be addressed in a follow-up ticket.
|
Ignore the failing tests, they are known failures and unrelated to this PR. I am interested in knowing whether or not this is a reasonable approach for distinguishing between DI vs. platform artifacts to install. You don't have to worry too much about the Go if you don't want to. |
| if a.Builder != nil && a.Builder.DisplayName != starBuilder { | ||
| return false | ||
| } |
There was a problem hiding this comment.
This is the crux of the PR. If an artifact's builder is not a star-builder, it cannot match a DI ecosystem for install and will go through the usual State Tool artifact install.
ucodery
left a comment
ucodery
left a comment
There was a problem hiding this comment.
I am unfamiliar with state tool buildplan walking code, but the premise of this PR seems sound. I think that the viability of the star-builder won't last, so matching on a literal name seems to fit the scale of the fix.
https://activestatef.atlassian.net/browse/CP-1137
Ecosystem namespaces will contain a mix of dynamically-imported artifacts and platform-built artifacts.
DI artifacts produced by the star-builder should invoke an ecosystem-specific installation procedure.
Artifacts produced by other platform builders should be installed as normal.
Note: uninstallation will not work because depot artifacts are not tied to builders. This will need to be addressed in a follow-up ticket.