Conversation
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to ade23b5 in 16 seconds
More details
- Looked at
25lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. aw_client/client.py:383
- Draft comment:
Catchingreq.exceptions.ConnectionErroris too broad and might catch unrelated exceptions. Consider usingrequests.ConnectionErrorinstead. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment suggests a change in exception handling, which is relevant to the logic of the new method. However, the suggestion seems incorrect becausereqis an alias forrequests, making the current exception handling correct. The comment does not provide strong evidence for a necessary change.
I might be missing some context about the use ofreqas an alias, but the import statement clearly showsrequestsis aliased asreq. The comment seems to misunderstand this.
Given the import statement, the current exception handling is correct, and the comment's suggestion is unnecessary.
The comment should be deleted because it incorrectly suggests a change that is not needed due to the aliasing ofrequestsasreq.
Workflow ID: wflow_feg8zFC0PDWvykp0
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Adds
wait_for_startmethod toActivityWatchClientto wait for server start with timeout handling.wait_for_start(timeout: int = 10)toActivityWatchClientinclient.py.This description was created by
for ade23b5. It will automatically update as commits are pushed.