Skip to content

chore: hide API Browser link while running rust servers #614

Merged
ErikBjare merged 1 commit intoActivityWatch:masterfrom
0xbrayo:master
Jan 24, 2026
Merged

chore: hide API Browser link while running rust servers #614
ErikBjare merged 1 commit intoActivityWatch:masterfrom
0xbrayo:master

Conversation

@0xbrayo
Copy link
Copy Markdown
Member

@0xbrayo 0xbrayo commented Oct 21, 2024

Important

Remove broken "API Browser" link from Home.vue.

  • Behavior:
    • Removed broken "API Browser" link from Home.vue under the Resources section.

This description was created by Ellipsis for 89909b2. It will automatically update as commits are pushed.

Copy link
Copy Markdown
Contributor

@ellipsis-dev ellipsis-dev Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 89909b2 in 7 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. src/views/Home.vue:55
  • Draft comment:
    Ensure that the API Browser link is indeed broken and not just temporarily down. If there are other references to the API Browser elsewhere in the codebase, consider removing or updating them as well.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR removes a broken link to the API Browser. This is a straightforward change, but it's important to ensure that the link is indeed broken and not just temporarily down. Additionally, it's good to check if there are any other references to the API Browser elsewhere in the codebase that might also need removal or updating.

Workflow ID: wflow_WhC3Il8RHx8KPkom


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@0xbrayo 0xbrayo changed the title chore: remove broke api browser link chore: remove broken api browser link Oct 21, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 21, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.98%. Comparing base (291da6f) to head (848aeaf).
⚠️ Report is 45 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #614   +/-   ##
=======================================
  Coverage   25.98%   25.98%           
=======================================
  Files          27       27           
  Lines        1643     1643           
  Branches      279      287    +8     
=======================================
  Hits          427      427           
+ Misses       1190     1157   -33     
- Partials       26       59   +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ErikBjare
Copy link
Copy Markdown
Member

Only broken in aw-server-rust, works fine for aw-server-python.

@0xbrayo
Copy link
Copy Markdown
Member Author

0xbrayo commented Oct 22, 2024

I figured most people are running the rust server. I can just wrap in it in a v-if block to display only on python server.

@ErikBjare
Copy link
Copy Markdown
Member

Sounds good!

@0xbrayo 0xbrayo force-pushed the master branch 2 times, most recently from 9ea531a to 8027166 Compare October 24, 2024 19:02
@0xbrayo 0xbrayo closed this Oct 25, 2024
@0xbrayo 0xbrayo reopened this Oct 25, 2024
@0xbrayo 0xbrayo changed the title chore: remove broken api browser link chore: hide API Browser link while running rust servers Apr 13, 2025
@0xbrayo
Copy link
Copy Markdown
Member Author

0xbrayo commented Apr 13, 2025

@ErikBjare ping

@ErikBjare ErikBjare merged commit a0e70bc into ActivityWatch:master Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants