Skip to content

fix: add another name for Brave#653

Merged
ErikBjare merged 1 commit intoActivityWatch:masterfrom
BelKed:brave-name
Mar 5, 2025
Merged

fix: add another name for Brave#653
ErikBjare merged 1 commit intoActivityWatch:masterfrom
BelKed:brave-name

Conversation

@BelKed
Copy link
Copy Markdown
Contributor

@BelKed BelKed commented Mar 5, 2025


Important

Adds brave-browser to browser_appnames in src/queries.ts to fix issue #165 by recognizing an alternative name for the Brave browser.

  • Behavior:
    • Adds brave-browser to the brave array in browser_appnames in src/queries.ts to recognize an alternative name for the Brave browser.
  • Issue Fix:

This description was created by Ellipsis for 0a5ca4f. It will automatically update as commits are pushed.

Copy link
Copy Markdown
Contributor

@ellipsis-dev ellipsis-dev Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 0a5ca4f in 26 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. src/queries.ts:275
  • Draft comment:
    Ensure the added 'brave-browser' string is a distinct, necessary variant. Consider verifying case sensitivity to avoid redundancy with 'Brave-browser'.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
2. src/queries.ts:276
  • Draft comment:
    Added alias 'brave-browser' for Brave. Consider adding an inline comment noting this change (e.g., linking to issue #165) to clarify why the lowercase variant is needed.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
3. src/queries.ts:105
  • Draft comment:
    Typo detected: In the comment on line 105, 'unecessary' should be corrected to 'unnecessary' to avoid confusion.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. src/queries.ts:103
  • Draft comment:
    Typographical error: The comment on line 103 uses "it's" (which means 'it is') but should use the possessive "its" (indicating ownership). Please update it for correctness.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_OPNHGAxScxWhW46t


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.76%. Comparing base (1b9d787) to head (0a5ca4f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #653   +/-   ##
=======================================
  Coverage   26.76%   26.76%           
=======================================
  Files          28       28           
  Lines        1655     1655           
  Branches      292      288    -4     
=======================================
  Hits          443      443           
  Misses       1155     1155           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ErikBjare ErikBjare merged commit f64e785 into ActivityWatch:master Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting custom browser name doesn't work.

2 participants