fix: add another name for Brave#653
Merged
ErikBjare merged 1 commit intoActivityWatch:masterfrom Mar 5, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 0a5ca4f in 26 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
4drafted comments based on config settings.
1. src/queries.ts:275
- Draft comment:
Ensure the added 'brave-browser' string is a distinct, necessary variant. Consider verifying case sensitivity to avoid redundancy with 'Brave-browser'. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
2. src/queries.ts:276
- Draft comment:
Added alias 'brave-browser' for Brave. Consider adding an inline comment noting this change (e.g., linking to issue #165) to clarify why the lowercase variant is needed. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
3. src/queries.ts:105
- Draft comment:
Typo detected: In the comment on line 105, 'unecessary' should be corrected to 'unnecessary' to avoid confusion. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. src/queries.ts:103
- Draft comment:
Typographical error: The comment on line 103 uses "it's" (which means 'it is') but should use the possessive "its" (indicating ownership). Please update it for correctness. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_OPNHGAxScxWhW46t
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #653 +/- ##
=======================================
Coverage 26.76% 26.76%
=======================================
Files 28 28
Lines 1655 1655
Branches 292 288 -4
=======================================
Hits 443 443
Misses 1155 1155
Partials 57 57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Adds
brave-browsertobrowser_appnamesinsrc/queries.tsto fix issue #165 by recognizing an alternative name for the Brave browser.brave-browserto thebravearray inbrowser_appnamesinsrc/queries.tsto recognize an alternative name for the Brave browser.aw-watcher-webwherebrave-browserwas not recognized.This description was created by
for 0a5ca4f. It will automatically update as commits are pushed.