Skip to content

Add an extension to bring SFSymbols to the SwiftUI Label#1

Merged
ActuallyTaylor merged 3 commits intoActuallyTaylor:mainfrom
mallman:label_symbol
Aug 6, 2023
Merged

Add an extension to bring SFSymbols to the SwiftUI Label#1
ActuallyTaylor merged 3 commits intoActuallyTaylor:mainfrom
mallman:label_symbol

Conversation

@mallman
Copy link
Contributor

@mallman mallman commented Aug 6, 2023

Add an extension to bring SFSymbols to the SwiftUI Label.

Please change code formatting to your liking. I will not be offended.

@mallman
Copy link
Contributor Author

mallman commented Aug 6, 2023

I just noticed that Label will bump up the version requirements for the platforms in your package. If you want, I can modify my PR to update those deps in the package descriptor. Or I can add version requirement macros around the Label extension. LMK.

@ActuallyTaylor
Copy link
Owner

This all looks really good, thank you a ton! I just updated the formatting and added an availability check so there should be no need to bump the entire package version.

@ActuallyTaylor ActuallyTaylor merged commit 00ef111 into ActuallyTaylor:main Aug 6, 2023
@mallman mallman deleted the label_symbol branch August 6, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants