PX1065: The DAC field property "Attributes" has Acumatica attributes declared on it but does not have a corresponding BQL field

[EvanTrow]

With Acuminator 4.0.0 on a DAC extension for BAccount it is throwing a PX1065 error for a field on the base DAC.

My code:

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using PX.Data;
using PX.Data.BQL;
using PX.Objects.CR;

namespace MyCustomization
{
    public sealed class BAccountExt : PXCacheExtension<BAccount>
    {
        public static bool IsActive() => CWBanyanParameters.BanyanEnabled;

        #region UsrBanyanBillingID
        [PXDBString(100)]
        [PXUIField(DisplayName = "Banyan Billing ID")]
        public string UsrBanyanBillingID { get; set; }
        public abstract class usrBanyanBillingID : BqlString.Field<usrBanyanBillingID> { }
        #endregion
    }
}

Similar error on SOShipLine:

[SENya1990]

@EvanTrow, in both cases there are real issues with base Acumatica DACs BAccount and SOShipLIne. The diagnostic warns authors of DAC extensions about problems in the base DAC, so they are wary about the problem fields. So, in my understanding this is not a false alert but the code analysis being conservative which means the analysis reports errors even in scenarios when the problem DAC fields are not relevant.

It is understandable that you cannot do anything about a base DAC which is located in Acumatica code. But on the other hand, this helps Acumatica to find issues in its DACs.

I will discuss this matter with my teammates and I also am interested in the opinion of Acuminator users on this matter. Please feel free to write it here. Currently, I think that the base DACs with issues should be reported from DAC extensions to allow Acumatica fix them. And the errors in DAC extensions should be suppressed with the Acuminator suppression comment.

To use the Acuminator suppression comment, you need to add a C# comment above the line with alert in the following format.

 // Acuminator disable once <diagnostic ID> <optional diagnostic short name> <optional justification>

You can write the comment manually but there is no reason for it. Acuminator provides the code fix that will generate the comment automatically, as shown in the following screenshot.

This will generate a comment like this (for the PX1003 diagnostic which is displayed on the screenshot)

// Acuminator disable once PX1003 NonSpecificPXGraphCreateInstance [Justification]

It is recommended to replace the [Justification] placeholder with a reason for the suppression of the alert, as the following example shows.

// Acuminator disable once PX1003 NonSpecificPXGraphCreateInstance Justification: specifically prepared graph is needed in this case
var graph = new PXGraph();

[SENya1990]

Created PR that will enhance PX1065 to report the error when the problem DAC field is in base DAC only if the DAC extension or derived DAC redeclare / override the DAC field with the problem.