Merged
Conversation
arl
requested changes
Feb 3, 2021
Collaborator
arl
left a comment
There was a problem hiding this comment.
Some comments here and there to update and the end-to-end test also, but the non-test code looks good to me.
Good job 👍
Codecov Report
@@ Coverage Diff @@
## main #122 +/- ##
==========================================
+ Coverage 45.95% 46.33% +0.38%
==========================================
Files 52 52
Lines 3669 3695 +26
==========================================
+ Hits 1686 1712 +26
Misses 1791 1791
Partials 192 192
Continue to review full report at Codecov.
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ What
Make it possible to declare Record validation from TOML. A new
Validationkey is added in the TOML, where the user can set a regex for each of the field names.To avoid conflicts the validation could be omitted or set just one time either on the Component object or in the TOML.
🔨 How to test
✅ Checklists
make gofmt-writebeen run on the code?make govetbeen run on the code? Has the code been fixed accordingly to the output?