awsutils: new package for aws-specific utilities#14
Merged
Conversation
tommyblue
approved these changes
Jul 28, 2020
Contributor
tommyblue
left a comment
tommyblue
left a comment
There was a problem hiding this comment.
LGTM, just 2 minor comments
| "sa-east-1": {}, | ||
| } | ||
|
|
||
| // IsValidRegion reports whether a region is a valid aws region string. |
Contributor
There was a problem hiding this comment.
Suggested change
| // IsValidRegion reports whether a region is a valid aws region string. | |
| // IsValidRegion reports whether a region is a valid AWS region identifier. |
- `awsDefaultBackoff` becomes `awsutils.DefaultBackoff` - `regions` map becomes `awsutils.IsValidRegion(region string)` func
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ What
Describe what this pull request does.
Introduce
awsutilspackage, at the moment it contains:awsDefaultBackoffbecomesawsutils.DefaultBackoffregionsmap becomesawsutils.IsValidRegion(region string)funcmake the necessary changes to the other package that were using those values.
🔨 How to test
✅ Checklists
This section contains a list of checklists for common uses, please delete the checklists that are useless for your current use case (or add another checklist if your use case isn't covered yet).
make gofmt-writebeen run on the code?make govetbeen run on the code? Has the code been fixed accordingly to the output?