Skip to content

filter: add ClearFields#19

Merged
arl merged 2 commits intomasterfrom
add-clear-fields-filter
Jul 31, 2020
Merged

filter: add ClearFields#19
arl merged 2 commits intomasterfrom
add-clear-fields-filter

Conversation

@arl
Copy link
Copy Markdown
Collaborator

@arl arl commented Jul 31, 2020

❓ What

Add ClearFields filter

This filter is required for an AdRoll internal tool. Since it's very generic, I'm adding it to the open-source repository.
It's a simple filter which you can configure giving it a set of record field names, each of those fields are going to be cleared when passing through this filter.

🔨 How to test

  1. List all steps necessary;
  2. To test this pull request.

✅ Checklists

This section contains a list of checklists for common uses, please delete the checklists that are useless for your current use case (or add another checklist if your use case isn't covered yet).

  • Is there unit/integration test coverage for all new and/or changed functionality added in this PR?
  • Have the changes in this PR been functionally tested?
  • Has make gofmt-write been run on the code?
  • Has make govet been run on the code? Has the code been fixed accordingly to the output?
  • Have the changes been added to the CHANGELOG.md file?
  • Have the steps in CONTRIBUTING.md been followed to update a Go module?

@arl arl changed the title filer: add ClearFields filter: add ClearFields Jul 31, 2020
@arl arl requested a review from tommyblue July 31, 2020 12:01
@arl
Copy link
Copy Markdown
Collaborator Author

arl commented Jul 31, 2020

Merging this myself. This is just a copy-paste of a filter we use in the compare-tool, an AdRoll internal tool.

@arl arl merged commit 0f11103 into master Jul 31, 2020
@arl arl deleted the add-clear-fields-filter branch July 31, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant