Merged
Conversation
tommyblue
force-pushed
the
restore_list_s3_manifest
branch
3 times, most recently
from
7e0c139 to
dd1b342
Compare
tommyblue
force-pushed
the
restore_list_s3_manifest
branch
from
dd1b342 to
e314f16
Compare
arl
approved these changes
Sep 17, 2020
Comment on lines
+339
to
+350
| } else { | ||
| resp, err := s.svc.GetObject(&s3.GetObjectInput{ | ||
| Bucket: aws.String(u.Host), | ||
| Key: aws.String(u.Path), | ||
| }) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| s.processListFile(resp.Body) | ||
| resp.Body.Close() | ||
| return nil |
Collaborator
There was a problem hiding this comment.
nit: better to return at the end of the if so as to avoid the else and un-indent the highlighted code
Contributor
Author
There was a problem hiding this comment.
@arl I did with the else (that I generally avoid) because the end of the if is unreachable (all the returns are inside the for loop. So I thought that, in this case, the if/else is a bit clearer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ What
#35 removed an expected functionality of the List input: consuming a S3 manifest file containing a list of files to download and ingest.
This PR restores it back
✅ Checklists
make gofmt-writebeen run on the code?make govetbeen run on the code? Has the code been fixed accordingly to the output?