Skip to content

Open source timestamp range filter#46

Merged
arl merged 5 commits intomainfrom
open-source-timestamp-range-filter
Sep 22, 2020
Merged

Open source timestamp range filter#46
arl merged 5 commits intomainfrom
open-source-timestamp-range-filter

Conversation

@arl
Copy link
Copy Markdown
Collaborator

@arl arl commented Sep 21, 2020

❓ What

Add a new filter which discard records if the value of a field containing a timestamp is out of the given time range (i.e StartDateTime <= value < EndDateTime)

🔨 How to test

  1. List all steps necessary;
  2. To test this pull request.

✅ Checklists

This section contains a list of checklists for common uses, please delete the checklists that are useless for your current use case (or add another checklist if your use case isn't covered yet).

  • Is there unit/integration test coverage for all new and/or changed functionality added in this PR?
  • Have the changes in this PR been functionally tested?
  • Has make gofmt-write been run on the code?
  • Has make govet been run on the code? Has the code been fixed accordingly to the output?
  • Have the changes been added to the CHANGELOG.md file?
  • Have the steps in CONTRIBUTING.md been followed to update a Go module?

@arl arl requested a review from tommyblue September 21, 2020 14:19
@arl arl force-pushed the open-source-timestamp-range-filter branch from e289dd4 to 704e5b0 Compare September 21, 2020 14:54
Copy link
Copy Markdown
Contributor

@tommyblue tommyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread filter/timestamp_range.go Outdated
Co-authored-by: Tommaso Visconti <tommaso.visconti@adroll.com>
@arl arl merged commit 7c3203f into main Sep 22, 2020
@arl arl deleted the open-source-timestamp-range-filter branch September 22, 2020 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants