Skip to content

Add buffercache#55

Merged
arl merged 9 commits intomainfrom
add-buffercache
Sep 30, 2020
Merged

Add buffercache#55
arl merged 9 commits intomainfrom
add-buffercache

Conversation

@arl
Copy link
Copy Markdown
Collaborator

@arl arl commented Sep 30, 2020

❓ What

Add BufferCache and SplitWriter reusable components in pkg.
Move awsutils into ./pkg

🔨 How to test

  1. List all steps necessary;
  2. To test this pull request.

✅ Checklists

This section contains a list of checklists for common uses, please delete the checklists that are useless for your current use case (or add another checklist if your use case isn't covered yet).

  • Is there unit/integration test coverage for all new and/or changed functionality added in this PR?
  • Have the changes in this PR been functionally tested?
  • Has make gofmt-write been run on the code?
  • Has make govet been run on the code? Has the code been fixed accordingly to the output?
  • Have the changes been added to the CHANGELOG.md file?
  • Have the steps in CONTRIBUTING.md been followed to update a Go module?

@arl arl requested a review from tommyblue September 30, 2020 10:03
Copy link
Copy Markdown
Contributor

@tommyblue tommyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, what do you think of adding a paragraph in the readme to explain the existence of those pkgs and how/why to use them?

@arl
Copy link
Copy Markdown
Collaborator Author

arl commented Sep 30, 2020

lgtm, what do you think of adding a paragraph in the readme to explain the existence of those pkgs and how/why to use them?

I can state the existence of pkg in the readme , though I'm not sure about the utility of going into further details there, these packages have good name and documentation which makes them pretty self-explanatory.

@arl arl merged commit 8765355 into main Sep 30, 2020
@arl arl deleted the add-buffercache branch September 30, 2020 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants