Conversation
1f4921a to
6aa0a9a
Compare
tommyblue
reviewed
Nov 16, 2020
Contributor
|
perfect |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ What
This is another step in the direction of making baker a full-featured binary one can use without touching code.
This gives the possibilty to defined field mapping in TOML. What we call fIeld mapping is a two-way mapping from field indexes and field names.
Before this change, one had to provide 2 function
FieldNameandFieldByNameinto baker.Components, even for super basic use of baker. Now you can specify this in TOML, from which 2 closures are generated and assigned into these 2 functions. This is done inNewConfigFromTOML.🔨 How to test
✅ Checklists
This section contains a list of checklists for common uses, please delete the checklists that are useless for your current use case (or add another checklist if your use case isn't covered yet).
make gofmt-writebeen run on the code?make govetbeen run on the code? Has the code been fixed accordingly to the output?