Conversation
adstage-jason
approved these changes
Oct 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Production warehouse instance has a large amount of tables, and makes heavy use of TOAST tables. Also every one of our extension tables are tables with 1000 columns of numeric arrays
Because Postgrex uses the binary wire protocol, it relies on maintaining an internal ETS
Elixir.Postgrex.Typestable to encode and decode types using OIDs. Which would be fine, except that the bootstrap query used in Postgrex pulled in way too much data, and blew up the memory usage of the table.Solution
Modified fix as suggested in elixir-ecto#320, BUT we change a top level predicate from
(t.typelem = 0 OR t.typelem NOT IN (SELECT oid FROM pg_catalog.pg_type WHERE typrelid!=0))to(t.typelem = 0 OR t.typelem IN (SELECT oid FROM pg_catalog.pg_type WHERE typrelid = 0)), because the suggested version of the query times out after 5 minutes.This makes the bootstrap query as follows:
Which returns 168 rows, instead of 311450 rows.