-
Notifications
You must be signed in to change notification settings - Fork 43
Bumblebees - Jamie H. #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…s, and .env file.
…to_dict and from_dict.
…outes_utilities file. Creates CRUD routes and specifically the sort by asc/desc one required for wave 2.
…as 'complete' or 'incomplete'.
…t__.py to include that info in app.config.
…ATCH request on an existing database entry with 'tasks/<id>/mark_complete'
…n Goal and Task. A goal has many tasks, a task belongs to one goal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your implementation looks good overall! Please review my comments, and let me know if you have any questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. This recsolves all the initial feedback points, but introduces a new situation around the /goal/id endpoint. Please take a look at that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for the updates.
| if not response.ok: | ||
| print(f"Error sending message to Slack: {response.text}") | ||
|
|
||
| def build_task_completion_message(task): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Great. In a fuller application, we might have a lot more functionality dedicated to the Slack integration, leading to additional classes and modules to organize them all together.
| "id": 1, | ||
| "title": "Build a habit of going outside daily", | ||
| "tasks": [] | ||
| "title": "Build a habit of going outside daily" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
| def get_one_goal(goal_id): | ||
| goal = validate_model(Goal, goal_id) | ||
| return {"goal": goal.to_dict_with_tasks()} | ||
| return {"goal": goal.to_dict()} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
No description provided.