Skip to content

Conversation

@johendrickson
Copy link

No description provided.

Katemar007 added a commit to Katemar007/task-list-api that referenced this pull request May 9, 2025
Copy link

@anselrognlie anselrognlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your implementation looks good overall! Please review my comments, and let me know if you have any questions.

Copy link

@anselrognlie anselrognlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. This recsolves all the initial feedback points, but introduces a new situation around the /goal/id endpoint. Please take a look at that.

Copy link

@anselrognlie anselrognlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the updates.

if not response.ok:
print(f"Error sending message to Slack: {response.text}")

def build_task_completion_message(task):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great. In a fuller application, we might have a lot more functionality dedicated to the Slack integration, leading to additional classes and modules to organize them all together.

"id": 1,
"title": "Build a habit of going outside daily",
"tasks": []
"title": "Build a habit of going outside daily"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

def get_one_goal(goal_id):
goal = validate_model(Goal, goal_id)
return {"goal": goal.to_dict_with_tasks()}
return {"goal": goal.to_dict()}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants