Comp new pcf8574 #404
Closed
Comp new pcf8574 #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Fabien-Chouteau
requested changes
May 2, 2022
Member
Fabien-Chouteau
left a comment
Fabien-Chouteau
left a comment
There was a problem hiding this comment.
Thanks for the contribution @RREE.
I have a couple comments.
| Val : I2C_Data (1 .. 1); | ||
| Status : I2C_Status; | ||
| begin | ||
| This.Port.Receive (This.Addr, Val, Status); |
Member
There was a problem hiding this comment.
This.Port is potentially null, you should check that before.
Same thing for the Set procedure.
…declared without initialization
…y into comp_new_pcf8574
Member
|
See #405 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PCF8574 is an old and simple io-expander from the 90ies without data direction register nor latch. GPIO_Pin cannot be implemented (I think). It is widely used in small LCD displays.