Add new Device_Id package body for F7x, which uses a different address#470
Merged
Conversation
jklmnn
requested changes
May 6, 2026
Member
jklmnn
left a comment
There was a problem hiding this comment.
You also have to adjust boards/stm32_f4ve/stm32_f4ve_full.gpr.
Contributor
Author
|
I added the F4ve gpr files but the builds still fail. Unfortuantely I cannot see the details to know what causes the failures. When I expand them all I can see is "Error" and nothing else. |
Member
It seems that boards/stm32f4xx_m/stm32f4xx_m_full.gpr is also missing the entry. I wasn't aware that the log of the CI is not public. If you want to check it locally you can run The CI is also running but that is usually not where it fails. |
Contributor
Author
|
I wasn't aware that the log of the CI is not public.
If you want to check it locally you can run
|python3 scripts/build_all_examples.py |
OK, thanks. Will do.
It would be good to make it publicly visible.
|
jklmnn
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The F7x series supports unique device identifiers but the id value is at a diferent address than the F4x series. The package interface is the same, therefore we create separate directories for the different package bodies containing the different addresses. One directory for the F4x containing the original package body, one for the F7x for the new package body with the new address.
Modified the board-specific gpr files to reference these device-specific directories.
Modified the Python file that generates the board-specific gpr files to include these new directories.