Fix toolchain localization issues (Implements gprbuild#163)#18
Closed
delta-lima7 wants to merge 1 commit intoAdaCore:masterfrom
Closed
Fix toolchain localization issues (Implements gprbuild#163)#18delta-lima7 wants to merge 1 commit intoAdaCore:masterfrom
delta-lima7 wants to merge 1 commit intoAdaCore:masterfrom
Conversation
Compilers like GCC provide localized messages when the system is configured with a non-english locale. This change sets the LC_MESSAGES variable to `C` so that always the default version info is used for searching in the knowledge base. (Applies AdaCore/gprbuild#163)
|
|
Collaborator
|
Hi @delta-lima7, the master branch is not the default branch by default anymore. Could you cherry-pick your patch to the "main" branch? |
Contributor
Author
|
Thanks for noticing! I somehow didn't when I encountered strange rebase conflicts. I cherry-picked and pushed to main, but it seems I'm unable to change the PR base branch. |
Collaborator
|
You may have to close this PR and open another based on main directly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements AdaCore/gprbuild#163 as requested.
Unfortunately, I am unable to get libgpr2 to build on my system and also really haven't got the time to figure it out. So the testing is on you. However, I think it should be fine.
Best regards,
Paul Martin