Replace self.shell with Run from e3 in testsuite #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TurboGit
previously approved these changes
Jun 27, 2022
Collaborator
TurboGit
left a comment
TurboGit
left a comment
There was a problem hiding this comment.
Thanks, please squash & merge.
Rlimit would cause crashes in Windows tests. It was used by e3.testsuite when calling self.shell, and would result into the following error: "rlimit: cannot spawn process (error 0x2)". Fix this with a replacement with Run, from e3.os.process, which should not call any bug. TN: V223-017
ghost
dismissed
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rlimit would cause crashes in Windows tests. It was used by e3.testsuite
when calling self.shell, and would result into the following error:
"rlimit: cannot spawn process (error 0x2)".
Fix this with a replacement with Run, from e3.os.process, which should
not call any bug.
TN: V223-017