Fix tests on Windows #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 29, 2022 10:55
Two problems fixed: - Bug introduced in previous merge request that would crash Run by giving it a bad kwarg. Reverted to self.shell, but used the e3.sys.interpreter to be more flexible. - Replaced the tests naming by setting a tests_subdir instead of a test_name method, which would crash Windows tests. TN: V223-017
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Pascal,
I did some changes as the tests would crash on Windows (and on Linux, really I did mistakes on the previous PR).
Sorry for the many PRs. This should be good, at last.
Will squash when change is accepted.
Victor.
TN : 223-017