Skip to content

Conversation

@kelsey-steven-ada
Copy link
Contributor

@kelsey-steven-ada kelsey-steven-ada commented Aug 20, 2025

Asana Task

Solution branch used to test CLI and test updates

Changes

  • Removes outer "task" and "goal" wrappers for create and get one route responses
    • Updates Wave docs
    • Updates tests
    • Updates CLI to no longer look for "task" wrapper in parse_task_from_response
  • Small updates to wave doc organization
    • Pulls general testing info that is similar between waves out of the tips sections so that "Tips" is more focused on info specific to each wave.
    • There was a lot of information around helper functions that was repeated on every relevant endpoint. Repeated info was moved into the tips section to help folks have a clear place to look for that info and hopefully suss out the requirements/new information easier since they aren't skimming through repeated info.

@kelsey-steven-ada kelsey-steven-ada force-pushed the ks_update_response_structure branch from a8851fd to 7a466fe Compare August 27, 2025 16:25
Copy link
Contributor

@apradoada apradoada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks good! I noticed one extra place where we could remove some redundancy and then just a couple of other small changes that might make everything a little more clear!

Co-authored-by: apradoada <110429145+apradoada@users.noreply.github.com>
Copy link
Contributor

@apradoada apradoada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@kelsey-steven-ada kelsey-steven-ada merged commit b38524c into main Aug 27, 2025
@kelsey-steven-ada kelsey-steven-ada deleted the ks_update_response_structure branch August 27, 2025 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants