Ap add tests for route helpers #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelsey-steven-ada
approved these changes
Aug 25, 2025
Contributor
kelsey-steven-ada
left a comment
kelsey-steven-ada
left a comment
There was a problem hiding this comment.
Left a suggestion for discussion and one to bring a test in line with prior wave expectations.
Co-authored-by: Kelsey Steven <97124999+kelsey-steven-ada@users.noreply.github.com>
Co-authored-by: Kelsey Steven <97124999+kelsey-steven-ada@users.noreply.github.com>
kelsey-steven-ada
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates related to this asana task.
Added tests in
test_wave_01.pyto test the Task model'sto_dictandfrom_dictmethods. These methods are mentioned in the wave 01 documents so seeing them tested should not be a surprise.Added tests in
test_wave_05.pyto test the Goal model'sto_dictandfrom_dictmethods. These methods are mentioned in the wave 01 documents so seeing them tested should not be a surprise.Added verbiage to
wave_07.mdto expand wave 07 to include refactoring as a requirement. Instructions are left intentionally vague in order to help students work on reading tests and using previous examples to help guide their solutions.Added a file,
test_wave_07.pyto test thevalidate_modelandcreate_modelhelpers that are now expected.