feat: add 'tail' note type and unify LabNoteType definitions#25
Merged
AdaInTheLab merged 1 commit intomainfrom Apr 16, 2026
Merged
feat: add 'tail' note type and unify LabNoteType definitions#25AdaInTheLab merged 1 commit intomainfrom
AdaInTheLab merged 1 commit intomainfrom
Conversation
😼 Carmel Judgment Stamp™🟪 Carmel Judgment Stamp™
This automated judgment has been issued by the Chief Judgment Office (CJO). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"tail"as a newLabNoteTypeacross the entire codebasesrc/types/labNotes.ts)"weather"was missing fromUpsertBody, and"lore","weather"were missing fromApiLabNoteWhat changed
src/types/labNotes.ts— Added"tail"toLabNoteTypeunion andALLOWED_NOTE_TYPESsetsrc/types/UpsertBody.ts— Added"weather"and"tail"to the type field unionsrc/api/data/labNotesStore.ts— Added"lore","weather","tail"toApiLabNote.typesrc/mappers/labNotesMapper.ts— Removed local duplicateLabNoteType,LabNoteStatus, andALLOWED_NOTE_TYPES; now imports fromtypes/labNotes.ts. Added"tail"category fallback inderiveTypeWhy
The mapper had a local copy of the type union that diverged from the canonical definition in
types/labNotes.ts. Adding"tail"in one place but not the others caused type inconsistencies. This PR fixes the drift and ensures all four files reference or mirror the same set of allowed types.Test plan
npx tsc --noEmit— cleannpm test— 41/41 passing🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com