chore(ogar-from-ruff): flip ruff deps back to branch=main (field_type merged)#142
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b5ec494e6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # `branch = "main"` once that ruff PR merges. | ||
| ruff_spo_triplet = { git = "https://github.com/AdaWorldAPI/ruff", rev = "4860e7987aa0c9453f812bb0178962d1cba66df0" } | ||
| ruff_spo_address = { git = "https://github.com/AdaWorldAPI/ruff", rev = "4860e7987aa0c9453f812bb0178962d1cba66df0" } | ||
| ruff_spo_triplet = { git = "https://github.com/AdaWorldAPI/ruff", branch = "main" } |
There was a problem hiding this comment.
With this dependency now resolving to ruff main, a fresh build of ogar-from-ruff pulls a ruff_spo_triplet::Field that does not yet expose field_type, while project_odoo_fields still assigns field.field_type in crates/ogar-from-ruff/src/lib.rs:228. The removed rev contains that field, so this change makes the crate fail to compile for anyone resolving dependencies from main; keep the pin or update after the upstream branch actually includes the field.
Useful? React with 👍 / 👎.
2 participants
Follow-up to #141. ruff #37 (
field_typecapture + thesocoperator-veto fix) is now merged to ruffmain, so the temporary rev-pin to4860e79that #141 introduced is no longer needed.Restores
branch = "main"for bothruff_spo_tripletandruff_spo_addressand drops the temporary-pin comment. No code change;Field.field_typeis on ruffmain, soproject_odoo_fieldsresolves against it.Generated by Claude Code