-
Notifications
You must be signed in to change notification settings - Fork 0
fix(ogar-vocab): repair EnterEffect placement after #13 (main doesn't compile) #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
e64cf4f
fix(ogar-vocab): repair EnterEffect placement after #13 (breaks main)
AdaWorldAPI 1434104
fix(ogar-vocab): restore #[non_exhaustive] on EnterEffect (Codex P2 o…
AdaWorldAPI f24ad9e
fix(ogar-emitter): repair on_enter call sites after EnterEffect type …
AdaWorldAPI File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because
EnterEffectis a public vocabulary struct and the module docs promise every public struct/enum is forward-compatible via#[non_exhaustive], leaving this type exhaustive lets downstream crates construct it with a literal and makes adding the planned typed value fields a semver-breaking change. Please put#[non_exhaustive]back onEnterEffectafter moving it.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in the latest push.
#[non_exhaustive]restored onEnterEffect, ordered after the derives to matchActionDef's convention in this crate. Tests still compile —#[non_exhaustive]only restricts external-crate construction; the in-crateassert_eq!(e, EnterEffect { ... })literal is permitted withinogar-vocabitself. This makes the planned typed-value tightening ofto_value(and any other future fields) a non-breaking change for downstream consumers.