docs(adr): implementation receipts addendum — 6+1 ADRs Pinned -> Implemented#22
Conversation
…ed -> Implemented Closes the loop on the ADR doc by recording the bardioc-side Rubicon Phase 1 -> 4 implementation receipts handed off after PR #21 merged. Six ADRs moved from 'Pinned' to 'Pinned + Implemented': ADR-001 (State=ActionState lifecycle) — bardioc 9412c68 (6/6) ADR-002 (split ActionDef/ActionInvocation) — bardioc 9412c68 (6/6) ADR-005 (typed EnterEffect) — bardioc 9412c68 + OGAR #15 ADR-007 (canonical state_machine signatures) — ractor_actors @ 38a71a4 (7/7) ADR-008 (commit_event sibling) — lance-graph #467 + bardioc 8c74c18 (13/13) ADR-009 (temporal two-axis engine) — lance-graph #468 + bardioc b055bfc (20/20) Plus the §14 acceptance gate (referenced by ADR-018 + multiple SUBSTRATE- ENDGAME / TRANSCODING sections) — bardioc Phase 4 43b272a (25/25). One ADR moved to 'Pinned (half-implemented)': ADR-010 (knowable_from meet-point) — consumer side live (lance-graph #468); producer side stubbed (OGAR #18 ogar-adapter-surrealql awaiting lance-bind Sprint-5b + rust-version bump). Closed-loop end-to-end documented in the addendum: ActionDef -> on_event -> evaluate_guard (StateGuard + Depends) -> Goto(Committed) -> on_commit -> LanceMembraneWriter -> commit_event(row) -> version bump + LanceVersionWatcher fan-out -> next Pending evaluates against post-commit deinterlace. Per-ADR receipts table + remaining-Pinned table with each unlock condition. Cumulative status table summarising 6 Pinned+Implemented / 1 half / 14 Pinned awaiting (the expected distribution: most ADRs are architectural decisions whose implementation lands incrementally as the ecosystem matures). Index table at top updated to reflect new statuses for receipt-bearing ADRs. Other ADR statuses unchanged. Bardioc-side anchor in MIGRATION_SPINE.md §2 + CROSS_SESSION_COORDINATION.md carries the parallel record; the docs are mutually-anchored. Pure docs; no code changes. https://claude.ai/code/session_01PBTGaPCSnnt6u3pjXpbLwY
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2736291dbc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| substrate's wider ecosystem matures. The closed-loop core (ADR-001 | ||
| through ADR-009) is now fully wired; the migration scaffold, OP- |
There was a problem hiding this comment.
Clarify which core ADRs are implemented
This sentence says the closed-loop core ADR-001 through ADR-009 is fully wired, but the status summary immediately above still leaves ADR-003, ADR-004, and ADR-006 in the Pinned/awaiting bucket. Future sessions using this ADR file as the authoritative implementation map can incorrectly treat those three decisions as implemented; please narrow the statement to the six implemented ADRs or update the statuses consistently.
Useful? React with 👍 / 👎.
ADR addendum — implementation receipts
Applies the receipt block handed off after PR #21 merged. Six ADRs move from Pinned to Pinned + Implemented with concrete bardioc commits + test counts; one (ADR-010) is Pinned (half-implemented) — consumer side live on lance-graph main, producer side stubbed pending the rust-version bump.
New "Implementation receipts" section
Inserted between the ADRs and Cross-references. Contains:
State=ActionState) ← bardioc9412c68(6/6, incl.one_machine_type_drives_every_domaintest)ActionDef/ActionInvocation) ← bardioc9412c68(6/6)EnterEffect) ← bardioc9412c68+ OGAR fix(ogar-vocab): repair EnterEffect placement after #13 (main doesn't compile) #15 (ogar-emitterstructural emission)state_machinesignatures) ←ractor_actorsfeat/state-machine-actor @ 38a71a4(7/7)commit_eventsibling) ← lance-graph PR #467 + bardioc Phase 28c74c18(13/13)b055bfc(20/20)43b272a(25/25;OracleSubstratetrait + fourVerdict+compare_normalised+MinimalChessOracledrop-in)Index table at top updated
Status column updated for ADR-001/002/005/007/008/009 (Pinned → Pinned + Implemented) and ADR-010 (Pinned → Pinned half-implemented). Other rows unchanged.
Why this addendum
Future sessions citing an ADR now resolve to both the architectural decision and the executable proof. Bidirectional resolution: forward (decision → commit), backward (commit → why-this-shape via ADR).
Parallel record in bardioc-owned
MIGRATION_SPINE.md §2+CROSS_SESSION_COORDINATION.md(cited in the addendum); the two docs are mutually-anchored.Pure docs
No code or vocab changes; just receipt-tracking.
https://claude.ai/code/session_01PBTGaPCSnnt6u3pjXpbLwY