feat(ogar-adapter-surrealql): wire surrealdb-parser deps + syntax validation (ADR-017 partial close)

[AdaWorldAPI]

ogar-adapter-surrealql parse wire-up — deps + syntax validation + smoke tests

Follow-up to PR #23 (rust-version 1.85 → 1.95 bump + ecosystem pin matrix). Now that the rust-version blocker is cleared, this PR wires up surrealdb-ast + surrealdb-parser under the surrealdb-parser feature flag and drives the parser for syntax validation.

What lands

Cargo.toml:

• surrealdb-parser feature now activates real deps: surrealdb-ast + surrealdb-parser, both taken from the workspace's pinned git refs (AdaWorldAPI/surrealdb#main, per PR chore: bump rust-version 1.85 -> 1.95 (mandatory ecosystem pin alignment) #23's [workspace.dependencies]).
• Default build (no features) doesn't pull the deps in — keeps the crate lightweight for consumers that only need emit_surrealql_ddl.

src/lib.rs:

• ParseError gains Unimplemented(String) variant + Display + std::error::Error impls (proper error type, no more todo!() panic).
• parse_surrealql_ddl(input):
  • Without feature: returns Err(ParseError::Unimplemented("…feature not enabled…")).
  • With --features surrealdb-parser: drives Parser::enter_parse::<surrealdb_ast::Query>(input, Config). On parse-OK, returns Err(ParseError::Unimplemented("DDL parsed successfully; AST → Class walk pending follow-up sprint")). On syntax error, returns Err(ParseError::Parse(error_message)).
• Three smoke tests gated by feature combo: feature-on valid DDL → Unimplemented(parsed-OK); feature-on invalid DDL → Parse(error); feature-off any DDL → Unimplemented(feature off).
• Crate docs reframed: the rust-version blocker note removed (no longer applies post PR chore: bump rust-version 1.85 -> 1.95 (mandatory ecosystem pin alignment) #23), replaced with a "Status post PR chore: bump rust-version 1.85 -> 1.95 (mandatory ecosystem pin alignment) #23" section + a canonical parser invocation pattern documenting the full Query → TopLevelExpr → Expr::DefineTable / DefineField → Ident.text arena-walk chain. Future follow-up walk impl doesn't have to re-derive it.

Scope honesty: partial close, not full close, of ADR-017

This PR moves ADR-017 from "blocked, scaffold only" to "deps wired, parser driven, syntax validation working" — but the AST → Class walk itself is the substantive follow-up sprint because:

• The surrealdb-ast is arena-allocated (NodeId<T>-indexed via Ast<L>).
• Each DefineTable / DefineField walk goes through ~6 layers of indirection (Query.exprs → NodeListId<TopLevelExpr> → TopLevelExpr::Expr → NodeId<Expr> → Expr::DefineTable(NodeId<DefineTable>) → DefineTable.name: NodeId<Expr> → Expr::Ident(NodeId<Ident>) → Ident.text: NodeId<String>).
• DefineField has ty: Option<NodeId<Type>> — the Type enum represents record<X> / option<X> / scalar / etc., each needing a different Class mapping per OGAR-AST-CONTRACT.md §2.
• Realistic walk impl is ~250-400 lines + handles all the Type variants + supports ASSERT $value IN [...] for EnumDecl::Static mapping.

Shipping it as a separate, focused follow-up PR avoids overcommitting on a complex internal-API walk in one PR (the EnterEffect cascade lesson from PR #13/#15).

What this enables for the follow-up

The follow-up walk PR can directly target the canonical pattern documented in src/lib.rs crate docs. The smoke tests provide the wiring proof; the walk impl just has to fill in the body.

register_class_knowable_from still stubbed

That's the §10.3 producer side of the knowable_from meet-point (ADR-010). It needs a Lance dataset writer in addition to the parser-side wiring. Tracked as a separate follow-up that pairs with the lance-bind Sprint-5b boundary.

Verification

• cargo check --workspace should succeed (no consumers of the new deps yet by default).
• cargo test --workspace should succeed (existing 12 emit tests + 1 feature-off smoke test).
• cargo test --workspace --features ogar-adapter-surrealql/surrealdb-parser (or however the workspace exposes it) should succeed (12 emit + 2 feature-on smoke tests; 1 feature-off test skipped).
• Note: I haven't been able to run cargo locally in this session, so CI is the ground truth.

https://claude.ai/code/session_01PBTGaPCSnnt6u3pjXpbLwY

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 79884570db

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Avoid resolving parser git deps in default builds

With these optional git dependencies in the package manifest, Cargo still resolves/fetches them while generating the dependency graph even when surrealdb-parser is not enabled, so emit-only/default users are no longer insulated from the private/remote SurrealDB fork. I checked cargo test -p ogar-adapter-surrealql --no-default-features, and it failed before compiling because Cargo tried to update https://github.com/AdaWorldAPI/surrealdb for surrealdb-ast; in offline CI or consumers without access to that fork, the default build now breaks despite the feature being off.

Useful? React with 👍 / 👎.