fix(ogar-adapter-surrealql): quote non-bare identifiers in emitted DDL

[AdaWorldAPI]

Summary

Closes Codex P2 on PR #33 (now merged) — register_class_knowable_from with surrealql-hint was rendering invalid SurrealQL for Odoo-style class names like sale.order because the emitter wrote DEFINE TABLE sale.order (dot terminates the bare identifier).

Per your instruction, opening this as a fresh PR for visibility since #33 is already on main.

The bug Codex flagged

Enabling surrealql-hint for Odoo-style classes stores an invalid schema hint instead of a self-describing registry entry.

OGAR class names legitimately use the dotted form (sale.order, account.move.line, res.partner) — ogar-ontology::class_identity documents this. SurrealQL bare identifiers match [A-Za-z_][A-Za-z0-9_]*; dots, hyphens, leading digits, and spaces need backtick-quoting.

The fix

New helper at crates/ogar-adapter-surrealql/src/lib.rs:

fn surrealql_ident(name: &str) -> String {
    if is_bare_surrealql_identifier(name) {
        name.to_string()
    } else {
        format!("`{}`", name.replace('`', "``"))
    }
}

Applied at every identifier-emission site:

Site	Identifier	Now quoted?
emit_class — DEFINE TABLE <name>	class.name	✓
emit_field_attr — DEFINE FIELD <name> ON <table>	attr.name + table (pre-quoted at emit_class)	✓
emit_field_assoc — DEFINE FIELD <name> ON <table> TYPE record<<target>>	assoc.name, target, table	✓
emit_field_enum — DEFINE FIELD <column> ON <table> TYPE …	enum_decl.column, table	✓

The non-owning-side comment marker (-- {table} HasMany …) is left un-quoted — it's not parsed; readable text serves better.

Walker side: zero changes needed

parse_surrealql_ddl extracts identifiers via Expr::Path { start: Ident { text }, parts: None } → ast[ident.text]. The SurrealDB parser unwraps backtick-quoting at the lexer level, so the walker yields "sale.order" (unquoted text) whether the DDL had backticks or not. Round-trip works automatically — verified by the new round-trip tests below.

Tests added (8 new)

Helper unit tests:

• bare_identifier_passes_through_unquoted
• non_bare_identifier_gets_backtick_quoted — covers sale.order, account.move.line, res.partner, kebab-case, leading digit, space
• embedded_backticks_get_doubled
• empty_string_is_not_a_bare_identifier

Emit-site tests:

• emit_class_with_odoo_dotted_name_quotes_the_table — asserts both DEFINE TABLE and DEFINE FIELD ON use the quoted form
• emit_class_with_odoo_belongs_to_quotes_record_target — asserts record<\res.partner`>` lands correctly

Round-trip (feature-on) tests — the load-bearing ones:

• round_trip_odoo_dotted_table_name — builds IR with sale.order + belongs_to → res.partner, emits, parses, asserts the IR survives the trip with names byte-identical.
• round_trip_three_segment_odoo_name — same for account.move.line.

Verification

$ cargo test -p ogar-adapter-surrealql                          -> 20/20
$ cargo test -p ogar-adapter-surrealql --features surrealdb-parser -> 33/33
$ cargo test -p ogar-knowable-from --features surrealql-hint    -> 10/10
$ cargo check --workspace --all-targets                         -> clean

PII abort-guard (word-boundary): CLEAN.

Scope

This fix is at the emit layer only — same change-policy as ADR-023 (the IR is fixed; adapter emit logic absorbs source-dialect concerns). No Class IR change; no adapter signature change; existing call sites with bare identifiers (widget, account, WorkPackage, etc.) pass through unchanged.

Note on the queue

PR #34 (docs/SPLAT-NATIVE-CUSTOMER.md) is the other session's work — leaving its Codex P2 to them per your instruction. This PR addresses only the OGAR session's own work.

https://claude.ai/code/session_01PBTGaPCSnnt6u3pjXpbLwY