fix: remove accumulator cyclic shift + add KNOWLEDGE.md Fixes the shift mismatch bug (PR review item #1): - accumulator.rs: removed cyclic shift from accumulate_frame(). crystallize() and unbind() now read/write the same cell positions. Decorrelation handled by ZeckBF17 golden-step at encoding level. - universal_perception.rs: same fix for UniversalAccumulator. - Removed unused PHI, GOLDEN_ANGLE, PI constants from both files. Added KNOWLEDGE.md: complete architectural reference for the Savant research agent. Documents the L2-scores-lower-than-L1 insight (integrated BitVec destroys plane separation), the correct two-curve Pareto frontier, all known bugs, and success criteria.#22
Merged
AdaWorldAPI merged 1 commit intomainfrom Mar 21, 2026
Merged
fix: remove accumulator cyclic shift + add KNOWLEDGE.md
Fixes the shift mismatch bug (PR review item #1):
- accumulator.rs: removed cyclic shift from accumulate_frame().
crystallize() and unbind() now read/write the same cell positions.
Decorrelation handled by ZeckBF17 golden-step at encoding level.
- universal_perception.rs: same fix for UniversalAccumulator.
- Removed unused PHI, GOLDEN_ANGLE, PI constants from both files.
Added KNOWLEDGE.md: complete architectural reference for the Savant
research agent. Documents the L2-scores-lower-than-L1 insight
(integrated BitVec destroys plane separation), the correct two-curve
Pareto frontier, all known bugs, and success criteria.#22AdaWorldAPI merged 1 commit intomainfrom
AdaWorldAPI merged 1 commit intomainfrom
Conversation
Fixes the shift mismatch bug (PR review item #1): - accumulator.rs: removed cyclic shift from accumulate_frame(). crystallize() and unbind() now read/write the same cell positions. Decorrelation handled by ZeckBF17 golden-step at encoding level. - universal_perception.rs: same fix for UniversalAccumulator. - Removed unused PHI, GOLDEN_ANGLE, PI constants from both files. Added KNOWLEDGE.md: complete architectural reference for the Savant research agent. Documents the L2-scores-lower-than-L1 insight (integrated BitVec destroys plane separation), the correct two-curve Pareto frontier, all known bugs, and success criteria.
AdaWorldAPI
pushed a commit
that referenced
this pull request
Apr 30, 2026
…ached_dtos + cohort_similarity_z SmbStack assembled facade closes the last review-open item from PR #21 (96fb069 + bb3df0b on smb-office-rs claude/review-csharp-rust-transcode-9ygcR). 27 smb-realtime tests pass, clippy clean. REQUEST: three upstream improvements to retire copy-pasted consumer caches in medcare-rs + smb-office-rs: 1. &'static Ontology factories (LazyLock-once, not allocate-per-call) 2. OntologyDto::cached_dtos -> CachedOntologyDtos { de, en } 3. lance_graph_contract::distance::cohort_similarity_z<F: Distance> Both consumers (medcare PR #73, smb PR #22) invented identical caches locally; promoting upstream eliminates the drift class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.