plan(sprint-13/spawn-gate): OQ-CSV-7..16 user-ratified + codex P2 follow-up — Wave I unblocked#393
Merged
Merged
Conversation
…ership from PP-4 to W-I4 Codex caught a residual CSI-19 owner-collision after the main cleanup pass: two sites in PP-3 rayon spec attributed the `--features rayon` CI matrix update to "PP-4" when PP-4 owns D-CSV-14 splat-on-Think (separate concern). Fix: reassign to W-I4 (sprint-13 sonnet impl worker assigned D-CSV-17 par_* streams). CI gate naturally belongs in the SAME ndarray PR as the par_* implementation it gates — keeps gate co-located with gated code; prevents silent-dead-code drift; eliminates the cross-planner ownership question. Two sites updated in pr-sprint-13-rayon-streams.md: - §8 risk-matrix row "Default-feature CI does not exercise" (line 560) - §10 cross-refs "PP-4: CI matrix update" bullet (line 586) Validates the four-agent quality lifecycle: the baton-handoff-auditor (PP-15) BAP7 D-id collision pattern fires on cross-planner ownership disagreements like this; the codex bot caught the same class manually this round; the preflight-drift-auditor (PP-16) PD6 spec-internal- contradiction pattern would have caught it pre-spawn if invoked.
…rker fleet (Wave I) unblocked User batch-ratified all 10 sprint-13 spawn blockers per PP-11 Opus recommendations at the post-PR-#392-merge gate-closing moment. Logged per protocol §3 in `.claude/knowledge/i4-substrate-decisions.md` §4. Ratified architectural commitments: OQ-CSV-7 (D-CSV-17 / W-I4) : rayon feature gate = `parallel` (match ndarray) OQ-CSV-8 (D-CSV-17 / W-I4) : chunk size = 8 rows Qualia / 4 rows SplatField (64B cache line) OQ-CSV-9 (D-CSV-14 / W-I2) : add `splat_field: Vec<SplatField>` to Think (+24B) OQ-CSV-10 (D-CSV-14 / W-I2) : SplatField::generation derives from self.cycle (single source of truth) OQ-CSV-11 (D-CSV-16 / W-I3) : SPO→256D via VSA bind of role-keyed fingerprints (Option A; per I-VSA-IDENTITIES) OQ-CSV-12 (D-CSV-16 / W-I3) : WitnessCorpus cam_pq = lazy via enable_cam_pq() (Option<CamPqState>) OQ-CSV-13 (D-CSV-13b / W-I1) : SIMD dispatch = runtime via simd_caps() (match ndarray) OQ-CSV-14 (D-CSV-13b / W-I1) : SHIP 4× / LAND 2× AVX-512 vs scalar speedup floor OQ-CSV-15 (all sprint-13) : WORKER edits Cargo.toml `members =` (W-G6 proven feasible) OQ-CSV-16 (governance) : iron-rules-doctrine → BOOT.md Tier-1 (already shipped via PR #391) Spawn-checklist final state: ✅ 1. PR #390 merge (lance-graph main 961baf8) ✅ 2. Wave H preflight PR merge (PR #391 → main 33eb812) ✅ 3. CSI-19 ID consolidation (PR #392 → main 1a037e4) ✅ 4. CSI-20 stale-claim sweep (PR #392 → main 1a037e4) ✅ 5. CSI-9 cross-repo ndarray PR (ndarray PR #147 → master e956e9d9) ✅ 6. OQ-CSV-7..16 user ratification (this commit) ✅ 7. PP-8 worker-template-v2 → canonical (PR #391) ✅ 8. PP-13 brutally-honest-tester → probation-tier (PR #391 BOOT.md) Also bundles the codex P2 fix from PR #392 (CI-matrix ownership PP-4 → W-I4) that didn't make the merge in time (commit a1d124c). After this PR merges, sprint-13 worker fleet (Wave I) dispatches as a single parallel fan-out: 4 Sonnet impl workers (W-I1..W-I4) per spec/branch + 1 Opus W-Meta-Opus for post-fleet honest review.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a52caa1a2b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+586
to
+587
| - W-I4 (sprint-13 sonnet impl worker assigned D-CSV-17): adds the | ||
| `--features rayon` row to ndarray's CI matrix in the same ndarray PR |
There was a problem hiding this comment.
This new W-I4 handoff still tells the ndarray worker to add a --features rayon CI row, but this same commit ratifies OQ-CSV-7 as feature gate parallel in .claude/knowledge/i4-substrate-decisions.md. If the worker follows that ratification and implements #[cfg(feature = "parallel")], the proposed CI command either fails for an unknown rayon feature or, worse, leaves the actual parallel-gated tests unexercised. Please update the D-CSV-17 handoff/checklist entries to use the ratified parallel gate consistently.
Useful? React with 👍 / 👎.
… OQ-CSV-7 (rayon → parallel) Codex P2 caught a consistency drift introduced by this same PR: PP-3 spec text still said '--features rayon' but this PR ratifies OQ-CSV-7 as feature gate `parallel` (match ndarray's existing convention). Workers following OQ-CSV-7 implement `#[cfg(feature = "parallel")]`; the proposed CI command would fail for an unknown `rayon` feature. Replaced all 9 '--features rayon' occurrences with '--features parallel' in pr-sprint-13-rayon-streams.md (lines 228/238/547/560/587/640/641/643/644). Also updated the line-560 risk-matrix prose to reference `#[cfg(feature = "parallel")]` consistently. W-I4 worker (sprint-13 sonnet impl, already dispatched) had the correct `parallel` in their spawn prompt; their impl PR will be clean. This commit fixes the doc surface for future readers + closes the codex P2 thread. Demonstrates the four-agent quality lifecycle working as designed: preflight-drift-auditor (PP-16) PD3 "pending-iron-rule-cited" + PD6 "spec-internal contradiction" would have caught this pre-spawn if invoked on this PR's diff against itself; codex caught it post-open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the final sprint-13 spawn gate. User batch-ratified all 10 OQ-CSV-7..16 architectural commitments per PP-11 Opus recommendations; logged to
i4-substrate-decisions.md §4per protocol §3. Also bundles the codex P2 follow-up from PR #392 (CI-matrix ownership reassign PP-4 → W-I4) that didn't make the merge in time.After merge: sprint-13 worker fleet (Wave I) dispatches.
Ratified architectural commitments
parallel(match ndarray)splat_field: Vec<SplatField>onThink(+24B)SplatField::generationderives fromself.cycleWitnessCorpus::enable_cam_pq()lazy viaOption<CamPqState>simd_caps()(match ndarray)Cargo.toml members =Spawn-checklist final state
961baf833eb8121a037e41a037e4e956e9d9Test plan
i4-substrate-decisions.md §4(new subsection "Sprint-13 ratifications")a1d124c— CI-matrix ownership PP-4 → W-I4 in pr-sprint-13-rayon-streams.md)After merge
Sprint-13 worker fleet dispatch (Wave I, single parallel fan-out):
.claude/specs/pr-sprint-13-simd-i4.md).claude/specs/pr-sprint-13-think-methods.md).claude/specs/pr-sprint-13-witness-cam-pq.md).claude/specs/pr-sprint-13-rayon-streams.md)https://claude.ai/code/session_01UwJuKqP828qyX1VkLgGJFS
Generated by Claude Code