Fix CI: pin to Rust 1.94.0, fix clippy warnings, fix feature gates#130
Merged
AdaWorldAPI merged 3 commits intomasterfrom Apr 30, 2026
Merged
Fix CI: pin to Rust 1.94.0, fix clippy warnings, fix feature gates#130AdaWorldAPI merged 3 commits intomasterfrom
AdaWorldAPI merged 3 commits intomasterfrom
Conversation
cursor
Bot
changed the title
cursor
Bot
changed the title
Co-authored-by: AdaWorldAPI <AdaWorldAPI@users.noreply.github.com>
…rison - src/simd_int_ops.rs: remove redundant parens in closure bodies (lines 287, 288) - src/hpc/vml.rs: remove redundant parens in closure body (line 478) - src/hpc/vnni_gemm.rs: remove redundant parens in closure body (line 318) - src/hpc/renderer.rs: replace useless >= 0 comparison on u64 with assert_eq!(_, 0) Co-authored-by: AdaWorldAPI <AdaWorldAPI@users.noreply.github.com>
These backends expose HPC functionality via the hpc module which is gated behind cfg(feature = "std"). Without this, --no-default-features --features native fails to find hpc::ocr_simd and other hpc modules. Also adds required-features = ["std"] to ocr_benchmark example as a safeguard. Co-authored-by: AdaWorldAPI <AdaWorldAPI@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/env-setup-bd77
branch
from
5ca9f1e to
2173938
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
1. Pin all CI to Rust 1.94.0
1.64.0,1.71.1) andstable/betavariantsrust-toolchain.toml(declareschannel = "1.94.0"+components = ["clippy", "rustfmt"])dtolnay/rust-toolchainworkarounds for clippy/rustfmt installation2. Fix 5 clippy warnings (
-D warnings)src/simd_int_ops.rs:287,288src/hpc/vml.rs:478src/hpc/vnni_gemm.rs:318src/hpc/renderer.rs:428u64 >= 0withassert_eq!(_, 0)3. Backend features now imply
stdThese backends expose HPC functionality via the
hpcmodule which iscfg(feature = "std"). Without this,--features nativewithout default features couldn't findhpc::*.4.
ocr_benchmarkexample gatedAdded
required-features = ["std"]as safeguard.5. AGENTS.md
Added Cursor Cloud specific development instructions.
Verification
RUSTFLAGS="-D warnings" cargo test --no-default-features --features native -p ndarray --no-run— compiles cleanRUSTFLAGS="-D warnings" cargo clippy --features native -- -D warnings— clean