refactor(substrate): graduate 5 modules from hpc/ to crate root (bitwise, heel_f64x8, distance, byte_scan, spatial_hash)#194
Merged
Conversation
Continues the substrate-graduation thread documented in #192's wrap-up and extended in #193's simd_caps lift. Five more modules move from `crate::hpc::*` (the rustynum migration staging area) to crate root where they sit alongside `simd.rs`, `simd_runtime/`, `simd_caps`, and the W1a polyfill surface they're supposed to compose with. | Module | Reason | |---|---| | `bitwise` | Pure SIMD primitives (popcount, hamming over byte slices); already uses `crate::simd::U64x8` polyfill internally; already re-exported via `simd.rs:512`. | | `heel_f64x8` | All-F64x8 polyfill consumer (dot, cosine, sum-sq, weighted-hamming); already re-exported via `simd.rs:563`. | | `distance` | Spatial 3D + slice-shape L1/L2/L∞ (PR-X10 A6); the linalg/mod.rs hard-boundary comment now points here at root. | | `byte_scan` | Pure SIMD utility (needle search, delimiter find). | | `spatial_hash` | Pure SIMD utility (bucketing, candidate gather). | # Why these five, why now All five satisfied the low-hanging-fruit criteria from #193's wrap-up discussion: 1. No internal `hpc/` dependencies (only `super::simd_caps` which still resolves correctly because `simd_caps` is itself at crate root post-#192). 2. Already polyfill-clean — no raw-intrinsic refactor needed before the move. 3. Already partially exposed via `crate::simd::*` re-exports. The next graduation tier (`fingerprint`, `dn_tree`, `ogit_bridge`, `splat3d`) needs a polyfill audit before it can move, and `fingerprint` in particular is gated on the W1a-#5 POPCOUNT-U64 primitive landing (so its bit ops can route through `U64xN.popcnt()` instead of raw `u64.count_ones()`). # Back-compat preserved end-to-end Every cross-repo consumer using `ndarray::hpc::{bitwise, heel_f64x8, distance, byte_scan, spatial_hash}::*` continues to compile unmodified. The `src/hpc/mod.rs` declarations change from `pub mod X;` to `pub use crate::X;` — Rust re-exports modules just like other items, so `crate::hpc::X::*` resolves through to the same items as `crate::X::*`. Internal `super::simd_caps::simd_caps()` calls inside the moved files continue to work because `super::` at crate root resolves to `crate::*` which has `simd_caps` (graduated in #192). # Changes - `git mv` five files from `src/hpc/` to `src/`. - `src/lib.rs` gains five `#[cfg(feature = "std")] pub mod X;` declarations next to the existing `simd_caps` block, each with a one-liner docstring naming the graduation source and the substrate-tier reason for the move. - `src/hpc/mod.rs` replaces five `pub mod X;` with `pub use crate::X;` (back-compat re-exports). - `src/hpc/linalg/mod.rs` updates the hard-boundary comment from "No distance metrics — those live in `crate::hpc::distance`" to point at `crate::distance` (the new canonical path) with a parenthetical noting the back-compat re-export. - The `bitwise.rs` declaration in `src/hpc/mod.rs` is now a comment instead of being interleaved with `pub mod hdc`/`pub mod projection` to make the graduation status visible at a glance. # Verification - `cargo build -p ndarray --lib` — clean - `cargo build -p ndarray --lib --no-default-features` — clean (the new `#[cfg(feature = "std")]` gates match the existing `simd_caps` pattern; nostd targets see no change) - `cargo test -p ndarray --lib bitwise:: distance:: heel_f64x8:: byte_scan:: spatial_hash::` — all 119 tests on the five graduated modules pass at the new path (test names now `bitwise::tests::*` rather than `hpc::bitwise::tests::*`) - `cargo test -p ndarray --lib --features "pillar,ogit_bridge, runtime-dispatch" hpc::` — 2167 passed, 0 failed, 28 ignored - `cargo fmt --all --check` — clean - `cargo clippy --features "pillar,ogit_bridge,runtime-dispatch" --lib -- -D warnings` — clean # Next graduation candidates (deferred) - `hpc::fingerprint` — needs W1a-#5 POPCOUNT-U64 to land first so bit ops can route through `U64xN.popcnt()` instead of raw `u64.count_ones()`. Cognitive-shader-foundation explicitly names `Fingerprint<N>` as a MUST-be-in-`ndarray::simd::*` type. - `hpc::dn_tree` (bitwise core) — same polyfill-audit dependency. The cognitive DNTree/DNConfig/TraversalHit state stays in `hpc/` after the split. - `hpc::ogit_bridge` — pure logic, no SIMD, can move once the fingerprint + dn_tree audits are out of the way (avoids three partial graduations in flight at once). - `hpc::splat3d` — already mostly polyfill-clean; pure path rewrite. Defer because it's a larger consumer surface than the five in this PR.
📝 WalkthroughWalkthroughFive std-only HPC/SIMD modules (bitwise, heel_f64x8, distance, byte_scan, spatial_hash) are exposed at the crate root; ChangesHPC module restructuring with back-compat re-exports and SIMD micro-refactors
🎯 3 (Moderate) | ⏱️ ~20 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/hpc/mod.rs`:
- Around line 30-31: The public re-exports (pub use crate::bitwise, pub use
crate::heel_f64x8, pub use crate::byte_scan, pub use crate::distance, pub use
crate::spatial_hash) are missing /// doc comments and examples; add triple-slash
documentation above each re-export describing the export and include a short
fenced rust example that references it (e.g. "use ndarray::hpc::bitwise as _;",
"use ndarray::hpc::heel_f64x8 as _;", and "use ndarray::hpc::{byte_scan as _,
distance as _, spatial_hash as _};") so the API carries required
docs/examples—apply the same change to the other re-export sites noted for
bitwise/HEEL/distance/byte_scan/spatial_hash.
In `@src/lib.rs`:
- Around line 275-302: The public modules bitwise, heel_f64x8, distance,
byte_scan, and spatial_hash lack runnable rustdoc examples; add a minimal `///`
doc example for each module (above the `pub mod ...` declarations) using a
fenced ```rust block that simply references the module to prove it compiles
(e.g. `use <crate>::bitwise as _;`) so the docs are exercisable; ensure each
example is wrapped in a code fence and marked rust, placed directly above the
corresponding `#[cfg(feature = "std")] pub mod <name>;` declarations for
bitwise, heel_f64x8, distance, byte_scan, and spatial_hash.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 3349d9c5-755d-4e7e-8481-c2cdf82be7d9
📒 Files selected for processing (8)
src/bitwise.rssrc/byte_scan.rssrc/distance.rssrc/heel_f64x8.rssrc/hpc/linalg/mod.rssrc/hpc/mod.rssrc/lib.rssrc/spatial_hash.rs
Comment on lines
+30
to
+31
| // Bitwise SIMD primitives — graduated to crate root. Back-compat re-export. | ||
| pub use crate::bitwise; |
There was a problem hiding this comment.
Document the new hpc public re-exports with /// examples.
These public re-exports currently use regular // comments (or none), so they miss required API docs/examples.
Proposed doc-comment patch
-// Bitwise SIMD primitives — graduated to crate root. Back-compat re-export.
+/// Bitwise SIMD primitives — graduated to crate root. Back-compat re-export.
+///
+/// ```rust
+/// use ndarray::hpc::bitwise as _;
+/// ```
pub use crate::bitwise;
@@
-// HEEL F64x8 distance kernels — graduated to crate root. Back-compat re-export.
+/// HEEL F64x8 distance kernels — graduated to crate root. Back-compat re-export.
+///
+/// ```rust
+/// use ndarray::hpc::heel_f64x8 as _;
+/// ```
pub use crate::heel_f64x8;
@@
-// SIMD-accelerated spatial / byte-scan / hash utilities — graduated to crate root.
-// Back-compat re-exports for existing `use ndarray::hpc::{distance,byte_scan,spatial_hash}::*`.
+/// SIMD-accelerated spatial / byte-scan / hash utilities — graduated to crate root.
+/// Back-compat re-exports for existing `use ndarray::hpc::{distance,byte_scan,spatial_hash}::*`.
+///
+/// ```rust
+/// use ndarray::hpc::{byte_scan as _, distance as _, spatial_hash as _};
+/// ```
pub use crate::byte_scan;
pub use crate::distance;
pub use crate::spatial_hash;As per coding guidelines: “All public APIs must include /// doc comments with examples”.
Also applies to: 60-61, 173-177
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/hpc/mod.rs` around lines 30 - 31, The public re-exports (pub use
crate::bitwise, pub use crate::heel_f64x8, pub use crate::byte_scan, pub use
crate::distance, pub use crate::spatial_hash) are missing /// doc comments and
examples; add triple-slash documentation above each re-export describing the
export and include a short fenced rust example that references it (e.g. "use
ndarray::hpc::bitwise as _;", "use ndarray::hpc::heel_f64x8 as _;", and "use
ndarray::hpc::{byte_scan as _, distance as _, spatial_hash as _};") so the API
carries required docs/examples—apply the same change to the other re-export
sites noted for bitwise/HEEL/distance/byte_scan/spatial_hash.
Two CI / review-feedback fixes on PR #194: 1) Clippy (`-D warnings`, --features rayon / approx,serde,rayon): 10 errors surfaced because the graduated modules are no longer under hpc/mod.rs's `#![allow(clippy::all, ...)]` umbrella. Fixed each at the canonical Rust idiom rather than re-applying the umbrella — graduated modules hold to the higher standard: - `bitwise.rs:110,155` — `acc = acc + (x + y);` → `acc += x + y;` (assign_op_pattern; bare without parens). - `distance.rs:99` — `for j in i..n { points[j] }` → `for p in &points[i..n] { p[0]..p[2] }` (needless_range_loop). - `byte_scan.rs:38,71` — `for j in i..n { if haystack[j] == needle { result.push(j); }}` → `for (offset, &byte) in haystack[i..n] .iter().enumerate() { if byte == needle { result.push(i + offset); }}` (needless_range_loop with index preservation). - `byte_scan.rs:101,129` — same pattern but counting via `total += 1`; switched to `for &byte in &haystack[i..n]` (no index needed at all). - `spatial_hash.rs:334` — `for lane in 0..8 { d2_arr[lane] }` → `for (lane, &d2_lane) in d2_arr.iter().enumerate()`. - `spatial_hash.rs:342` — `for i in (chunks*8)..candidates.len() { candidates[i] }` → `let tail_start = chunks * 8; for (offset, &cand) in candidates[tail_start..].iter() .enumerate() { result.push((tail_start + offset, d2)) }`. 2) CodeRabbit + CLAUDE.md hard rule ("All public APIs need /// doc comments with examples"): Added `# Example` rustdoc blocks to each of the five new `pub mod` declarations in `src/lib.rs`. Each example uses only the actual public API of the target module (verified by running the doctests): - `bitwise` — popcount + hamming over [0xFF; 16]/[0x00; 16] - `heel_f64x8` — cosine_f64_simd + dot_f64_simd over [1.0; 32] - `distance` — l1/l2/linf_f64_simd over pythagorean (3,0)/(0,4) - `byte_scan` — byte_find_all over a 23-char fixture - `spatial_hash` — SpatialHash::new + insert + len All five doctests pass under `cargo test --doc`. `cargo clippy --features rayon --lib -- -D warnings` and `cargo clippy --features approx,serde,rayon -- -D warnings` both green.
Continues the substrate-graduation thread from #192 (simd_caps), #193 (clippy/doc cleanup), and #194 (bitwise/heel_f64x8/distance/ byte_scan/spatial_hash). Same low-hanging-fruit criteria — no internal hpc/ deps, polyfill-clean, single-line back-compat shim keeps every existing import resolving. | Module | Reason | |---|---| | `aabb` | SIMD AABB intersection/expansion/distance; only deps are | | | `crate::simd::F32x16` + `super::simd_caps` (graduated #192). | | `nibble` | 4-bit packed nibble batch ops; only dep is `crate::simd::U8x64`.| | `palette_codec` | Variable-width palette index codec (1-8 bit packing); zero deps.| | `property_mask` | AVX-512 VPTERNLOGD bitset queries on block state bits; | | | only dep is `crate::simd::U64x8`. | # Why these four, why now All four satisfy the criteria from #194's wrap-up: 1. No internal `hpc/` dependencies — only `crate::simd::*` (polyfill surface) and `super::simd_caps` (which is itself at crate root post-#192). 2. Polyfill-clean — no raw-intrinsic refactor required. 3. Single in-tree downstream caller (`hpc::framebuffer` uses `palette_codec`) → the `pub use crate::palette_codec;` back-compat shim keeps that resolution working zero-touch. # Mechanical changes - `git mv src/hpc/{aabb,nibble,palette_codec,property_mask}.rs src/` - `src/lib.rs`: added four `pub mod` declarations under `#[cfg(feature = "std")]`, each with a `# Example` rustdoc block per CLAUDE.md "all public APIs need doc comments with examples". - `src/hpc/mod.rs`: replaced the four `pub mod` declarations with `pub use crate::{aabb, nibble, palette_codec, property_mask};` back-compat re-exports. `crate::hpc::aabb::*` and friends keep resolving for every existing call site, identical to how `crate::hpc::bitwise::*` works post-#194. # Clippy / lint cleanup 17 clippy errors surfaced under `-D warnings` once the modules left the `hpc/mod.rs` `#![allow(clippy::all, ...)]` umbrella. Fixed each at the canonical Rust idiom (the #194 cleanup pattern, 417131b), no umbrella re-application: - **manual_div_ceil (6 sites)** — `(n + d - 1) / d` → `n.div_ceil(d)` in `nibble.rs` (x2), `palette_codec.rs` (x3), `property_mask.rs`. - **needless_range_loop (10 sites)** — `for i in start..vec.len()` rewrites to `for x in &vec[start..]` (when index unused) or `for (i, &x) in iter().enumerate().skip(start)` (when index used). Sites: `aabb.rs` x4, `nibble.rs` x3, `palette_codec.rs` x1, `property_mask.rs` x2. - **missing_docs (4 sites)** — added field doc comments on `pub struct Aabb { min, max }` and `pub struct Ray { origin, inv_dir }`. Previously masked by the `hpc/mod.rs` umbrella's `#![allow(missing_docs)]`. # Doctest correction Initial `# Example` in `src/lib.rs` for `palette_codec` asserted `bits_for_palette_size(1) == 1` per the module's own docstring table, but the impl returns 0 for `palette_size <= 1` (trivial- palette special case). Changed assertion to use `bits_for_palette_ size(2) == 1` — exercises the same code path with input the impl actually handles per spec. # Verification ``` cargo check --lib green cargo clippy --lib -- -D warnings green cargo clippy --lib --features rayon -- -D warnings green cargo clippy --features approx,serde,rayon -- -D warnings green cargo test --doc (15 graduated-module doctests) pass cargo test --lib (104 unit tests across 4 modules) pass ``` # What's next `hpc/` inventory: ~55 → ~51 modules at the staging path. Next-batch candidates per the same criteria need a deps audit before move: `framebuffer` (uses `palette_codec` shim, otherwise crate-root), `ocr_simd`/`ocr_felt`, `audio`. Filed in AGENT_LOG entry for the follow-up pass. https://claude.ai/code/session_01HbqooFZHAjaUtFEzhA1R2u
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
src/hpc/mod.rs (1)
179-187:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winAdd rustdoc comments and examples for these new public re-exports.
These
pub useitems are public APIs but currently documented with//comments, so they miss required///docs with examples.📌 Suggested patch
-// Variable-width palette index codec — graduated to crate root. -// Back-compat re-export for existing `use ndarray::hpc::palette_codec::*`. +/// Variable-width palette index codec — graduated to crate root. +/// Back-compat re-export for existing `use ndarray::hpc::palette_codec::*`. +/// +/// ```rust +/// use ndarray::hpc::palette_codec as _; +/// ``` pub use crate::palette_codec; -// SIMD-accelerated HPC modules (block properties, nibble light data, AABB -// collision) — all three graduated to crate root. Back-compat re-exports. +/// Axis-aligned bounding box operations — crate-root module re-exported for back-compat. +/// +/// ```rust +/// use ndarray::hpc::aabb as _; +/// ``` pub use crate::aabb; +/// Nibble-packed 4-bit utilities — crate-root module re-exported for back-compat. +/// +/// ```rust +/// use ndarray::hpc::nibble as _; +/// ``` pub use crate::nibble; +/// Block property mask queries — crate-root module re-exported for back-compat. +/// +/// ```rust +/// use ndarray::hpc::property_mask as _; +/// ``` pub use crate::property_mask;As per coding guidelines: “All public APIs must include
///doc comments with examples”.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/hpc/mod.rs` around lines 179 - 187, The public re-exports palette_codec, aabb, nibble, and property_mask are missing rustdoc comments and examples; replace the inline `//` comments with `///` doc comments for each pub use (palette_codec, aabb, nibble, property_mask) and add a short docstring plus a minimal doctest example (e.g., ```rust\nuse ndarray::hpc::aabb as _;\n``` style) for each to satisfy the “public APIs must include /// doc comments with examples” guideline, ensuring each re-export has its own descriptive line and fenced-rust example.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.claude/board/AGENT_LOG.md:
- Around line 68-75: The fenced code block that contains the cargo commands in
.claude/board/AGENT_LOG.md is missing a language tag (triggering markdownlint
MD040); update the opening fence for that block (the one containing the lines
starting with "cargo check --lib" and subsequent cargo commands) from ``` to
```bash so the block is annotated as bash.
---
Duplicate comments:
In `@src/hpc/mod.rs`:
- Around line 179-187: The public re-exports palette_codec, aabb, nibble, and
property_mask are missing rustdoc comments and examples; replace the inline `//`
comments with `///` doc comments for each pub use (palette_codec, aabb, nibble,
property_mask) and add a short docstring plus a minimal doctest example (e.g.,
```rust\nuse ndarray::hpc::aabb as _;\n``` style) for each to satisfy the
“public APIs must include /// doc comments with examples” guideline, ensuring
each re-export has its own descriptive line and fenced-rust example.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: dd67c007-4910-477a-b063-9a88df9558d9
📒 Files selected for processing (7)
.claude/board/AGENT_LOG.mdsrc/aabb.rssrc/hpc/mod.rssrc/lib.rssrc/nibble.rssrc/palette_codec.rssrc/property_mask.rs
Comment on lines
+68
to
+75
| ``` | ||
| cargo check --lib → clean | ||
| cargo clippy --lib -- -D warnings → clean | ||
| cargo clippy --lib --features rayon -- -D warnings → clean | ||
| cargo clippy --features approx,serde,rayon -- -D warnings → clean | ||
| cargo test --doc (filtered: graduated modules) → 15 doctests pass | ||
| cargo test --lib aabb::tests nibble::tests palette_codec::tests property_mask::tests → 104 unit tests pass | ||
| ``` |
There was a problem hiding this comment.
Add a language tag to the fenced code block.
Line 68 opens a fenced block without a language, which triggers markdownlint MD040. Please annotate it (e.g., bash).
Suggested patch
-```
+```bash
cargo check --lib → clean
cargo clippy --lib -- -D warnings → clean
cargo clippy --lib --features rayon -- -D warnings → clean
cargo clippy --features approx,serde,rayon -- -D warnings → clean
cargo test --doc (filtered: graduated modules) → 15 doctests pass
cargo test --lib aabb::tests nibble::tests palette_codec::tests property_mask::tests → 104 unit tests pass</details>
<!-- suggestion_start -->
<details>
<summary>📝 Committable suggestion</summary>
> ‼️ **IMPORTANT**
> Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
```suggestion
🧰 Tools
🪛 markdownlint-cli2 (0.22.1)
[warning] 68-68: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.claude/board/AGENT_LOG.md around lines 68 - 75, The fenced code block that
contains the cargo commands in .claude/board/AGENT_LOG.md is missing a language
tag (triggering markdownlint MD040); update the opening fence for that block
(the one containing the lines starting with "cargo check --lib" and subsequent
cargo commands) from ``` to ```bash so the block is annotated as bash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Five-module substrate-graduation batch. Continues the thread documented in #192's wrap-up and extended in #193's
simd_capslift. Each module moves fromcrate::hpc::*(the rustynum migration staging area) to crate root where it sits alongsidesimd.rs,simd_runtime/,simd_caps, and the W1a polyfill surface it's supposed to compose with.bitwisepopcount_raw,hamming_distance_rawover byte slices); already usescrate::simd::U64x8polyfill internally; already re-exported viasimd.rs:512.heel_f64x8dot_f64_simd,cosine_f64_simd,sum_sq_f64_simd,cosine_f32_to_f64_simd,heel_weighted_distance/hamming); already re-exported viasimd.rs:563.distancelinalg/mod.rshard-boundary comment text gets a one-word update.byte_scanspatial_hashSelection criteria (the low-hanging-fruit test)
All five satisfied three criteria from the post-#193 graduation discussion:
hpc/dependencies. Onlysuper::simd_caps::simd_caps()calls — andsimd_capsalready lives at crate root (graduated in feat(simd_caps): CPUID 7,1 + new x86 caps fields + AMX OS-gate in cpu_ops (salvage from #190) #192), sosuper::resolution works in either parent location.crate::simd::*polyfilled types.crate::simd::*re-exports — so the graduation is consistent with the established public-surface flow.Back-compat preserved end-to-end
Every cross-repo consumer using
ndarray::hpc::{bitwise, heel_f64x8, distance, byte_scan, spatial_hash}::*continues to compile unmodified. Rust re-exports modules just like other items:pub use crate::X;insidecrate::hpc::modmakescrate::hpc::X::*resolve through to the same items ascrate::X::*.Internal
super::simd_caps::simd_caps()calls inside the moved files continue to work becausesuper::at crate root resolves tocrate::*, which hassimd_caps(from #192).Mechanical changes
src/lib.rsgains five#[cfg(feature = "std")] pub mod X;declarations next to the existingsimd_capsblock, each with a one-liner docstring naming the graduation source and the substrate-tier reason.src/hpc/mod.rsreplaces fivepub mod X;withpub use crate::X;(back-compat re-exports).src/hpc/linalg/mod.rsupdates the hard-boundary comment from "No distance metrics — those live incrate::hpc::distance" to point atcrate::distance(the new canonical path) with a parenthetical noting the back-compat re-export.Verification
cargo build -p ndarray --libcargo build -p ndarray --lib --no-default-features#[cfg(feature = "std")]gates match thesimd_capspattern; nostd targets see no changecargo test -p ndarray --lib bitwise:: distance:: heel_f64x8:: byte_scan:: spatial_hash::bitwise::tests::*rather thanhpc::bitwise::tests::*)cargo test -p ndarray --lib --features "pillar,ogit_bridge,runtime-dispatch" hpc::cargo fmt --all --checkcargo clippy --features "pillar,ogit_bridge,runtime-dispatch" --lib -- -D warningsNext graduation candidates (deferred to follow-up PRs)
hpc::fingerprintU64xN.popcnt()instead of rawu64.count_ones(). Cognitive-shader-foundation.md:32-33 explicitly namesFingerprint<N>as a MUST-be-in-ndarray::simd::*type.hpc::dn_tree(bitwise core)hpc/after the split.hpc::ogit_bridgehpc::splat3dThe mechanical pattern these five establish (move file → add
pub modat root → flippub modtopub use crate::Xinhpc/mod.rs) is the template each subsequent graduation will follow.Generated by Claude Code
Summary by CodeRabbit
Refactor
Documentation