feat(models): complete 1:1 OpenAI API surface + unified router#46
Merged
Conversation
Rewrite api_types.rs as single source of truth with exact OpenAI field
names and object types:
- CompletionRequest/Response with logprobs, stop, penalties, seed
- ChatCompletionRequest/Response with tools, streaming chunks, deltas
- EmbeddingRequest/Response with encoding_format, dimensions
- ImageGenerationRequest/Response with size parsing, quality, style
- Model/ModelList with object fields ("model", "list")
- ErrorResponse envelope matching OpenAI error format
- ChatRole with as_str()/from_str() for wire format
Add router.rs — unified ModelRouter dispatching by model ID:
- complete() → GPT-2
- chat_complete() → OpenChat 3.5 (or GPT-2 via chat↔completion adapter)
- embed() → GPT-2 wte (extensible to Jina/BERT)
- list_models() / get_model() → all registered models
- chat↔completion adapters for cross-model compatibility
Rewire gpt2/api.rs, openchat/api.rs, stable_diffusion/api.rs to use
shared types. No JSON/serde surface — pure Rust types for in-binary
consumers (q2, lance-graph).
58 API tests passing.
https://claude.ai/code/session_01Y69Vnw751w75iVSBRws7o7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite api_types.rs as single source of truth with exact OpenAI field
names and object types:
Add router.rs — unified ModelRouter dispatching by model ID:
Rewire gpt2/api.rs, openchat/api.rs, stable_diffusion/api.rs to use
shared types. No JSON/serde surface — pure Rust types for in-binary
consumers (q2, lance-graph).
58 API tests passing.
https://claude.ai/code/session_01Y69Vnw751w75iVSBRws7o7