feat: phyllotactic-manifold + p64 crates (additive, 44 tests)#64
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 750ca413c5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let result = self.attend(noisy, noise_level); | ||
| self.rows[result.best_idx as usize] |
There was a problem hiding this comment.
Make denoise_step honor the noise_level parameter
denoise_step passes noise_level into attend, but attend uses gamma only to build the fires bitmask and not to choose best_idx, so the returned row is identical for all noise_level values. This means the denoising schedule in denoise has no effect on the actual state updates, which breaks the intended coarse-to-fine behavior for every nontrivial denoising call.
Useful? React with 👍 / 👎.
| block_active = true; | ||
| interactions += 1; | ||
| } else { | ||
| pruned += 1; |
There was a problem hiding this comment.
Track sparse256 active_blocks at block granularity
from_clam_leaves increments interactions (and pruned) inside the inner 4×4 leaf-pair loop, but later publishes these as active_blocks/pruned_blocks. That counts leaf pairs rather than blocks, so reported block statistics can exceed total_blocks and misstate sparsity, which can mislead downstream tuning or pruning decisions that rely on these metrics.
Useful? React with 👍 / 👎.
feat: phyllotactic-manifold + p64 — 7+1 φ/γ spiral + 64×64 BNN palette
Two new standalone crates. Additive only — zero changes to existing files.
phyllotactic-manifold (876 LOC, 14 tests)
7+1 phyllotactic SIMD manifold with Euler-gamma singularity correction.
std::f64::consts::GOLDEN_RATIO+EULER_GAMMA<f, c>from resonance + contradictionp64 (1817 LOC, 23 tests)
Palette64: 64×64 BNN attention matrix from 8 phyllotactic HEEL planes.
#[repr(align(64))]Q AND K → POPCNT → Gamma thresholdsparse256 module:
Palette3D (4KB L1-resident):
Connection to existing stack
Bridge code (p64_bridge.rs, 695 LOC) ready for integration into ndarray
--features p64or as lance-graph consumer crate.