test: recursion_limit=1024 on remaining 22 test files (final fan-out)#8
Merged
Merged
Conversation
Completes the recursion_limit fan-out started in Sprints O (#1) and S (#5). All surrealdb/core/tests/*.rs files now carry the attribute so the upstream integration suite can be exercised against kv-lance via SURREAL_TEST_KV=lance without compile-time recursion errors. Files in this PR (alphabetical): - access.rs - alter.rs - asyncevent.rs - auth_limit.rs - cache.rs - changefeeds.rs - complex.rs - define.rs - field.rs - function.rs - future.rs - index.rs - info.rs - live.rs - param.rs - query.rs - remove.rs - script.rs - sequence.rs - table.rs - timeout.rs - util.rs Each file gets a single line: `#![recursion_limit = "1024"]` at the top (prepended to line 1). Inner attributes can appear in any order in Rust, so files that already had `#![allow(...)]` etc. are unaffected by the prepend. Combined with the 8 files done in O + S (create, select, update, delete, insert, upsert, merge, relate), this covers all 30 integration test files in surrealdb/core/tests/. Verification: per-PR cargo check + targeted per-file test runs under SURREAL_TEST_KV=lance will surface real semantic gaps in the kv-lance backend (separate from compile errors). Those land as followup sprints.
Owner
Author
|
Meta-V verified locally All 30 test binaries (including the 22 in this PR) compile cleanly under the combined Ready for merge. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final fan-out of the
#[recursion_limit = "1024"]pattern started in Sprint O (#1,tests/create.rs) and Sprint S (#5, 7 CRUD files). Brings all 30surrealdb/core/tests/*.rsfiles to a uniform state so the full upstream integration suite can be exercised underSURREAL_TEST_KV=lancewithout compile-time recursion errors.Files (22)
Why
When both
kv-lanceandkv-memfeatures are enabled (the combination is needed forSURREAL_TEST_KV=lancerouting viahelpers.rs::new_ds, because upstreamiam/file.rsrequirestempfilewhich iskv-mem-gated), the async-trait expansion insurrealdb_core::expr::expression::Expr::computeexceeds rustc's default recursion limit of 128.Same compile-time error pattern as #1 + #5:
Mechanical change
Each file gets a single line:
#[recursion_limit = "1024"]prepended to line 1. Rust permits inner attributes in any order, so files that already had#[allow(...)]or#[cfg(...)]inner attrs are unaffected. Zero runtime cost.Coverage after this PR
create.rsselect.rs,update.rs,delete.rs,insert.rs,upsert.rs,merge.rs,relate.rsTotal: 30/30 integration test files.
Test plan
cargo check --tests --features "kv-lance kv-mem" --no-default-featurescompiles all 30 test binaries (verified locally; running in background at PR-creation time).SURREAL_TEST_KV=lanceis the next-sprint deliverable; that data will be aggregated into.claude/lance-backend/KNOWN_DIFFERENCES.mdas semantic gaps are found.Followups
After this PR, the open KNOWN_DIFFERENCES items are:
SURREAL_TEST_KV=lance.Generated by Claude Code