Self-wrapping error detection

[Adam-Kay]

Introduction of new system whereby the programs wraps itself in itself as a container and monitors the internal program for critical errors (crashes). It can then safely handle these and show a message to the user before exiting.

Related issues:

• Fixes End of program error: The batch file cannot be found. #47
  
  
  

Createlist:

Separate¹ the Critical Error (code 3) into:

• Encoding Error (code 4)
  • for when something goes wrong during an encode (ffmpeg fails, output file does not exist or has wrong length)
• Critical Program Error (code 5)
  • for when the program crashes and the external wrapper has to catch it and produce an error

Testlist:

• Exiting program via entering N at first confirmation works
  • (program exits with no error messages as well as a clean %ERRORLEVEL%)
• Force exiting program via CTRL+C works
  • (program can exit without or with error message, as long as it's one or less)
• On Update Error, program restarts correctly
• On Encoding Error, program exits with one error message and an error code of 4
• On Critical Program Error, program crashes gracefully using external wrapper with only one error message and an error code of 5

then

• After restart (for instance as a result of update error), ensure all of the above still work correctly

Footnotes

1. These are separated into new codes so that 3 ends up somewhat 'deprecated'.
     ↩

[Adam-Kay]

Ideas from this SO thread might help determine if the program was launched by double-click or from terminal - in theory this should not matter but if I have to force behavior, this is how I'd do it.

[Adam-Kay]

Midnote

This project may benefit from a step back and re-attempt from scratch (< 69792ad), as code has gotten messy with comments and debugging for issues.

[Adam-Kay]

Two commits are missing from this branch and should be removed from main and added here:

• eeacec4
• 8decbbe

[Adam-Kay]

comment:

Two commits are missing from this branch and should be removed from main and added here

So, rebasing the main & self-wrapper branches and force pushing was scary but I think in theory this works.

[Adam-Kay]

History now reset to how it was before the rebase. Going to attempt again but preserving the dates this time.

[Adam-Kay]

Rebase is complete with intact history (though hashes will have changed)

For reference, the command used for rebasing was:

git rebase --interactive --rebase-merges --committer-date-is-author-date 7f7cdd4

Though I'm not sure --rebase-merges was necessary.

[Adam-Kay]

Added new tasks into PR description.