Skip to content

Fix ABTesting UpdateExperiments overflow policy binding#116

Merged
AdamEssenmacher merged 1 commit intomainfrom
codex/api-drift-abtesting-updateexperiments
Apr 10, 2026
Merged

Fix ABTesting UpdateExperiments overflow policy binding#116
AdamEssenmacher merged 1 commit intomainfrom
codex/api-drift-abtesting-updateexperiments

Conversation

@AdamEssenmacher
Copy link
Copy Markdown
Owner

Summary

  • correct Firebase.ABTesting.ExperimentController.UpdateExperiments to use the native overflow-policy enum instead of NSObject
  • add the missing ExperimentPayloadExperimentOverflowPolicy enum with the values defined in the Firebase ABTesting source
  • add a focused local E2E case that verifies the managed signature and a representative native call path
  • harden the local E2E runner so case-injected package references and packed local packages are restored deterministically

Validation

  • dotnet pack source/Firebase/ABTesting/ABTesting.csproj --configuration Release --output output
  • tools/e2e/run-firebase-foundation.sh --package-dir output --configuration Debug --runtime-drift-case abtesting-updateexperiments
  • tools/e2e/run-firebase-foundation.sh --package-dir output --configuration Debug

Notes

  • This is a real API-fidelity fix, not a runtime-failure remediation. The old NSObject parameter was too broad, but the selector still completed at runtime.
  • The runner changes are included because this case exposed two local validation issues: stale restore evaluation for case-injected package references and stale package extraction when reusing the same local package version.

@AdamEssenmacher
Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@AdamEssenmacher AdamEssenmacher merged commit 090809c into main Apr 10, 2026
1 check passed
@AdamEssenmacher AdamEssenmacher deleted the codex/api-drift-abtesting-updateexperiments branch April 10, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant