Add AppCheck limited-use token bindings#129
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Interesting, I didn't know about the limited token, so just for info on to what this binding just added:
Thanks! |
Summary
limitedUseTokenWithCompletion:.getLimitedUseTokenWithCompletion:to the AppCheck provider model and exposes it onAppCheckDebugProvider, which does not inherit the model surface directly.appcheck-limited-use-tokens.Notes
This keeps the binding thin: no task wrapper or convenience helper is added. The E2E case treats native App Check configuration/platform errors as acceptable after the selector crosses the native boundary, and still fails on binding-layer issues such as missing managed API, unrecognized selector, bad marshaling, or
ObjCRuntime.ObjCException.Out of scope for this slice: unrelated AppCheck provider APIs, audit tooling, Firestore cache settings, and broader backlog cleanup.
Validation
dotnet tool run dotnet-cake -- --target=nuget --names="Firebase.AppCheck"tools/e2e/run-firebase-foundation.sh --package-dir output --configuration Debug --runtime-drift-case appcheck-limited-use-tokenstools/e2e/run-firebase-foundation.sh --package-dir output --configuration Debuggit diff --checkTargeted E2E result:
RuntimeDrift:appcheck-limited-use-tokenspassed. The native selectorlimitedUseTokenWithCompletion:invoked its callback and returned a native App Check platform/OS error on simulator rather than a binding-layer exception.