[codex] Fix Firebase binding surface coverage false positives#154
Merged
AdamEssenmacher merged 1 commit intomainfrom Apr 14, 2026
Merged
[codex] Fix Firebase binding surface coverage false positives#154AdamEssenmacher merged 1 commit intomainfrom
AdamEssenmacher merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Core.Appvs reflected runtime names such asFirebase.Core.App.Root Cause
The exhaustive E2E coverage harness was stricter than the generated binding runtime shape in two places:
[Export]metadata used by the binding generator, but they do not correspond to real Objective-C classes or writable runtime properties.Validation
dotnet test scripts/FirebaseBindingAudit.Tests/FirebaseBindingAudit.Tests.csproj --no-restoretools/e2e/run-firebase-foundation.sh --package-dir output --configuration Debug --binding-surface-target allgit diff --checkNotes
Unrelated local changes were intentionally left out of this PR:
docs/firebase-runtime-failure-backlog.mdand.github/workflows/firebase-e2e.yml.