Skip to content

[codex] Fix Firebase binding surface coverage false positives#154

Merged
AdamEssenmacher merged 1 commit intomainfrom
codex/fix-firebase-e2e-coverage-harness
Apr 14, 2026
Merged

[codex] Fix Firebase binding surface coverage false positives#154
AdamEssenmacher merged 1 commit intomainfrom
codex/fix-firebase-e2e-coverage-harness

Conversation

@AdamEssenmacher
Copy link
Copy Markdown
Owner

Summary

  • Fixes Firebase binding surface coverage false positives from shorthand source type names such as Core.App vs reflected runtime names such as Firebase.Core.App.
  • Stops ApiDefinition helper/event-args exports from being treated as Objective-C class surfaces in the generated coverage inventory.
  • Adds regression coverage for notification event-args helper exports so they stay reflection-only instead of native-class probes.

Root Cause

The exhaustive E2E coverage harness was stricter than the generated binding runtime shape in two places:

  • Source inventory parameter names can use namespace shorthand while reflection reports fully qualified runtime type names.
  • Notification event-args helper interfaces can contain [Export] metadata used by the binding generator, but they do not correspond to real Objective-C classes or writable runtime properties.

Validation

  • dotnet test scripts/FirebaseBindingAudit.Tests/FirebaseBindingAudit.Tests.csproj --no-restore
    • Passed: 50/50
  • tools/e2e/run-firebase-foundation.sh --package-dir output --configuration Debug --binding-surface-target all
    • Passed
    • Binding surface coverage: 1507 surfaces, 1507 exercised, 0 waived, 0 failed
  • git diff --check
    • Passed

Notes

Unrelated local changes were intentionally left out of this PR: docs/firebase-runtime-failure-backlog.md and .github/workflows/firebase-e2e.yml.

@AdamEssenmacher AdamEssenmacher marked this pull request as ready for review April 14, 2026 04:25
@AdamEssenmacher AdamEssenmacher merged commit 6c8725e into main Apr 14, 2026
1 check passed
@AdamEssenmacher AdamEssenmacher deleted the codex/fix-firebase-e2e-coverage-harness branch April 14, 2026 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant