Skip to content
This repository was archived by the owner on Jul 11, 2025. It is now read-only.

Wrote 'Custom Editor Actions' page#24

Merged
ilexp merged 3 commits intoAdamsLair:masterfrom
deanljohnson:editor-action-page
May 24, 2018
Merged

Wrote 'Custom Editor Actions' page#24
ilexp merged 3 commits intoAdamsLair:masterfrom
deanljohnson:editor-action-page

Conversation

@deanljohnson
Copy link
Copy Markdown
Contributor

Summary

Wrote a docs page on "Custom Editor Actions"

Topics

  • What is an editor action?
  • EditorAction and EditorSingleAction
  • Retrieving EditorActions
  • Action contexts

I placed the page under the "advanced" category, but as more docs on extending the editor are written it might make more sense to move this into a new "Extending the Editor" category.

@ilexp ilexp added Page Request Creation of a new docs page / topic Editor Area: Duality editor or support libraries labels May 15, 2018
@ilexp ilexp requested a review from a team May 15, 2018 17:20
@ilexp
Copy link
Copy Markdown
Member

ilexp commented May 15, 2018

Pinging the @AdamsLair/duality-docs team for a first review

Copy link
Copy Markdown
Member

@ilexp ilexp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid explanation, brief and to the point 👍

@ilexp
Copy link
Copy Markdown
Member

ilexp commented May 24, 2018

I placed the page under the "advanced" category, but as more docs on extending the editor are written it might make more sense to move this into a new "Extending the Editor" category.

Sounds good. Maybe go with an "Editor" top-level category later on, and spread out from there. We're using top-level categories for most things right now, but as the number of articles grows, we should adopt a hierarchical structure, as done for the two Guidelines pages Best Practices and Common Pitfalls. The generation code is already in place, just need to use the parent page variable instead of category.

@ilexp ilexp merged commit e980a11 into AdamsLair:master May 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Editor Area: Duality editor or support libraries Page Request Creation of a new docs page / topic

Development

Successfully merging this pull request may close these issues.

2 participants