This repository was archived by the owner on Jul 11, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 289
This repository was archived by the owner on Jul 11, 2025. It is now read-only.
Rework Object Previews / PreviewProviders #294
Copy link
Copy link
Open
Labels
Breaking ChangeBreaks binary or source compatibilityBreaks binary or source compatibilityCleanupImproving form, keeping functionImproving form, keeping functionEditorArea: Duality editor or support librariesArea: Duality editor or support librariesFeatureIt doesn't exist yet, but I want itIt doesn't exist yet, but I want it
Milestone
Description
The aim of this issue has shifted away from a distinct editor module and towards a (DualityEditor) preview panel control, which is incorporated in the Object Inspector (plugin). See the first comment for more information.
Summary
Object previews are currently embedded directly into the Object Inspector. This leads to code duplication and needless limitations. Replace this concept with a new "Object Preview" editor module that simply displays a preview of the currently selected object(s).
Analysis
- With a custom (docking) editor module, previews can be adjusted by the user to fit any size, rather than being dependent on proprety editor sizes.
- It would be a lot easier for custom Resources to display a preview, since all that is needed is a custom
PreviewProvider, which is a lot easier to write and more versatile, as it is also used byContentRef<T>property editors, etc. - A lot of custom PropertyEditor code could be removed or unified after implementing this.
TexturePreviewPropertyEditor/TextureContentPropertyEditor/TexturePropertyEditorPixmapPreviewPropertyEditor/PixmapContentPropertyEditor/PixmapPropertyEditorFontPreviewPropertyEditor/FontContentPropertyEditor/FontPropertyEditorAudioDataPreviewPropertyEditor/AudioDataPropertyEditorImagePreviewPropertyEditor
- Releasing this package would also require releasing a new installer
.zippackage, since the list of default packages will have to be extended. - Should multiple instances of an Object Preview module be allowed?
- If yes, a selection coordination similar to the existing one in Object Inspector would be necessary.
- If not, there will no longer be a convenient per-selection-group preview like currently in a multi-inspector situation.
- Does this really add value? Questionable. Maybe limit to single-instance for now and extend later when needed.
Metadata
Metadata
Assignees
Labels
Breaking ChangeBreaks binary or source compatibilityBreaks binary or source compatibilityCleanupImproving form, keeping functionImproving form, keeping functionEditorArea: Duality editor or support librariesArea: Duality editor or support librariesFeatureIt doesn't exist yet, but I want itIt doesn't exist yet, but I want it