Issue/252 duplicate functions and unclear link function #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnellington
reviewed
Jan 28, 2025
Collaborator
cnellington
left a comment
cnellington
left a comment
There was a problem hiding this comment.
Requested some small changes, and also need to see the build tests pass (linting tests can fail for now). These should be automatic CI, but for some reason they aren't run here.
jxmils
force-pushed
the
issue/252-Duplicate-functions-and-unclear-link-function
branch
from
819829c to
a97f650
Compare
- Removed the 'linear' function and its constructor, keeping 'linear_link' and its constructor for consistency. - Updated 'identity' in 'LINK_FUNCTIONS' to correctly reference 'identity_link_constructor'. - Updated 'contributing.md' to include the correct 'make_docs.sh' file. - Ran 'format_style.sh' to ensure consistent code formatting across the project.
jxmils
force-pushed
the
issue/252-Duplicate-functions-and-unclear-link-function
branch
from
6181868 to
1497933
Compare
jxmils
force-pushed
the
issue/252-Duplicate-functions-and-unclear-link-function
branch
from
1497933 to
f8f0273
Compare
…d-unclear-link-function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Issue #252
linearfunction and its constructor, keepinglinear_linkand its constructor for consistency.identityin 'LINK_FUNCTIONS' to correctly referenceidentity_link_constructor.contributing.mdto include the correctmake_docs.shfile.logisticfunction.format_style.shmake_docs.sh