Skip to content

Adaptive UI: Added palette options for Okhsl#223

Merged
bheston merged 4 commits intomainfrom
users/bheston/aui-palette-options
Aug 23, 2024
Merged

Adaptive UI: Added palette options for Okhsl#223
bheston merged 4 commits intomainfrom
users/bheston/aui-palette-options

Conversation

@bheston
Copy link
Copy Markdown
Member

@bheston bheston commented Aug 23, 2024

Pull Request

Description

OK is the best algorithm we have for perceptual color, but the results are not always the intent we want in design. This PR adds some config options to the Okhsl palette:

  • Allow customization of the number of steps in the palette, which is useful to increase or decrease contrast in the base design
  • Set the saturation of the light and/or dark end to adjust the curve. Base colors with high saturation maintain that saturation even when the lightness is high, which makes them pop too much for some design intents.

Reviewer Notes

Additive changes to the palette.

Test Plan

Tested in Figma.

Checklist

General

  • I have included a change request file using $ npm run change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation for this project.

@bheston bheston self-assigned this Aug 23, 2024
Comment thread packages/adaptive-ui/src/core/color/palette-okhsl.ts Outdated
@bheston bheston force-pushed the users/bheston/aui-palette-options branch from f39f080 to 6965a86 Compare August 23, 2024 20:10
@bheston bheston merged commit 5b514fb into main Aug 23, 2024
@bheston bheston deleted the users/bheston/aui-palette-options branch August 23, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants